Skip to content

Fix race condition on resource tab reload#3965

Closed
TheodoreSpeaks wants to merge 1 commit intostagingfrom
fix/resource-tab-persist
Closed

Fix race condition on resource tab reload#3965
TheodoreSpeaks wants to merge 1 commit intostagingfrom
fix/resource-tab-persist

Conversation

@TheodoreSpeaks
Copy link
Copy Markdown
Collaborator

Summary

Brief description of what this PR does and why.

Fixes #(issue)

Type of Change

  • Bug fix
  • New feature
  • Breaking change
  • Documentation
  • Other: ___________

Testing

How has this been tested? What should reviewers focus on?

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

Screenshots/Videos

@vercel
Copy link
Copy Markdown

vercel bot commented Apr 5, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated (UTC)
docs Skipped Skipped Apr 5, 2026 1:45am

Request Review

@TheodoreSpeaks
Copy link
Copy Markdown
Collaborator Author

@BugBot review

@cursor
Copy link
Copy Markdown

cursor bot commented Apr 5, 2026

PR Summary

Low Risk
Low risk UI-state change that only affects URL syncing for the active resource; main risk is subtle navigation/history behavior differences.

Overview
Fixes a race in Home where the URL could be rewritten before an activeResourceId is established.

The activeResourceId→URL sync effect now skips its first run until a resource has been set at least once (via hasSetResourceRef), and it clears url.hash before calling history.replaceState to avoid persisting stale fragments when updating the resource query param.

Reviewed by Cursor Bugbot for commit c8c2b0d. Bugbot is set up for automated code reviews on this repo. Configure here.

Copy link
Copy Markdown

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Bugbot reviewed your changes and found no new issues!

Comment @cursor review or bugbot run to trigger another review on this PR

Reviewed by Cursor Bugbot for commit c8c2b0d. Configure here.

@waleedlatif1 waleedlatif1 deleted the fix/resource-tab-persist branch April 7, 2026 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant