Implement --until log filter flag.

Author: sinclairtarget

dump.go

@@ -17,6 +17,7 @@ func dump(
 	paths []string,
 	short bool,
 	since string,
+	until string,
 	authors []string,
 	nauthors []string,
 ) (err error) {
@@ -36,6 +37,8 @@ func dump(
 		short,
 		"since",
 		since,
+		"until",
+		until,
 		"authors",
 		authors,
 		"nauthors",
@@ -49,6 +52,7 @@ func dump(
 
 	filters := git.LogFilters{
 		Since:    since,
+		Until:    until,
 		Authors:  authors,
 		Nauthors: nauthors,
 	}

hist.go

@@ -25,6 +25,7 @@ func hist(
 	showEmail bool,
 	countMerges bool,
 	since string,
+	until string,
 	authors []string,
 	nauthors []string,
 ) (err error) {
@@ -48,6 +49,8 @@ func hist(
 		countMerges,
 		"since",
 		since,
+		"until",
+		until,
 		"authors",
 		authors,
 		"nauthors",
@@ -67,13 +70,14 @@ func hist(
 	populateDiffs := tallyOpts.IsDiffMode()
 	filters := git.LogFilters{
 		Since:    since,
+		Until:    until,
 		Authors:  authors,
 		Nauthors: nauthors,
 	}
 
 	var end time.Time // Default is zero time, meaning use last commit
-	if len(revs) == 1 && revs[0] == "HEAD" {
-		// If no revs given, end timeline at current time
+	if len(revs) == 1 && revs[0] == "HEAD" && len(until) == 0 {
+		// If no revs or --until given, end timeline at current time
 		end = time.Now()
 	}
 

internal/git/cmd.go

@@ -176,6 +176,7 @@ func run(
 
 type LogFilters struct {
 	Since    string
+	Until    string
 	Authors  []string
 	Nauthors []string
 }
@@ -188,6 +189,10 @@ func (f LogFilters) ToArgs() []string {
 		args = append(args, "--since", f.Since)
 	}
 
+	if f.Until != "" {
+		args = append(args, "--until", f.Until)
+	}
+
 	for _, author := range f.Authors {
 		args = append(args, "--author", author)
 	}

main.go

@@ -182,6 +182,7 @@ Usage: git-who table [options...] [revisions...] [[--] paths...]
 				*countMerges,
 				*limit,
 				*filterFlags.since,
+				*filterFlags.until,
 				filterFlags.authors,
 				filterFlags.nauthors,
 			)
@@ -256,6 +257,7 @@ Usage: git-who tree [options...] [revisions...] [[--] paths...]
 				*showHidden,
 				*countMerges,
 				*filterFlags.since,
+				*filterFlags.until,
 				filterFlags.authors,
 				filterFlags.nauthors,
 			)
@@ -311,6 +313,7 @@ Usage: git-who hist [options...] [revisions...] [[--] paths...]
 				*showEmail,
 				*countMerges,
 				*filterFlags.since,
+				*filterFlags.until,
 				filterFlags.authors,
 				filterFlags.nauthors,
 			)
@@ -337,6 +340,7 @@ func dumpCmd() command {
 				paths,
 				*short,
 				*filterFlags.since,
+				*filterFlags.until,
 				filterFlags.authors,
 				filterFlags.nauthors,
 			)
@@ -363,6 +367,7 @@ func parseCmd() command {
 				paths,
 				*short,
 				*filterFlags.since,
+				*filterFlags.until,
 				filterFlags.authors,
 				filterFlags.nauthors,
 			)
@@ -401,6 +406,7 @@ func isOnlyOne(flags ...bool) bool {
 
 type filterFlags struct {
 	since    *string
+	until    *string
 	authors  flagutils.SliceFlag
 	nauthors flagutils.SliceFlag
 }
@@ -410,6 +416,9 @@ func addFilterFlags(set *flag.FlagSet) *filterFlags {
 		since: set.String("since", "", strings.TrimSpace(`
 Only count commits after the given date. See git-commit(1) for valid date formats
 		`)),
+		until: set.String("until", "", strings.TrimSpace(`
+Only count commits before the given date. See git-commit(1) for valid date formats
+		`)),
 	}
 
 	set.Var(&flags.authors, "author", strings.TrimSpace(`

parse.go

@@ -17,6 +17,7 @@ func parse(
 	paths []string,
 	short bool,
 	since string,
+	until string,
 	authors []string,
 	nauthors []string,
 ) (err error) {
@@ -36,6 +37,8 @@ func parse(
 		short,
 		"since",
 		since,
+		"until",
+		until,
 		"authors",
 		authors,
 		"nauthors",
@@ -49,6 +52,7 @@ func parse(
 
 	filters := git.LogFilters{
 		Since:    since,
+		Until:    until,
 		Authors:  authors,
 		Nauthors: nauthors,
 	}

table.go

@@ -42,6 +42,7 @@ func table(
 	countMerges bool,
 	limit int,
 	since string,
+	until string,
 	authors []string,
 	nauthors []string,
 ) (err error) {
@@ -69,6 +70,8 @@ func table(
 		limit,
 		"since",
 		since,
+		"until",
+		until,
 		"authors",
 		authors,
 		"nauthors",
@@ -88,6 +91,7 @@ func table(
 	populateDiffs := tallyOpts.IsDiffMode()
 	filters := git.LogFilters{
 		Since:    since,
+		Until:    until,
 		Authors:  authors,
 		Nauthors: nauthors,
 	}

tree.go

@@ -47,6 +47,7 @@ func tree(
 	showHidden bool,
 	countMerges bool,
 	since string,
+	until string,
 	authors []string,
 	nauthors []string,
 ) (err error) {
@@ -74,6 +75,8 @@ func tree(
 		countMerges,
 		"since",
 		since,
+		"until",
+		until,
 		"authors",
 		authors,
 		"nauthors",
@@ -95,6 +98,7 @@ func tree(
 
 	filters := git.LogFilters{
 		Since:    since,
+		Until:    until,
 		Authors:  authors,
 		Nauthors: nauthors,
 	}