chore: fix pre-existing CI analyze failures#2728
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR addresses pre-existing CI failures that caused flutter analyze (and a follow-up commenter step) to fail in fork-based PRs, independent of the PR’s code quality.
Changes:
- Suppresses
experimental_member_usediagnostics inexample/andflutter_quill_extensions/via localanalysis_options.yaml. - Updates a deprecated
Matrix4.translateusage in the editor viewport paint transform. - Prevents the analyze-commenter GitHub Action step from failing the workflow by marking it
continue-on-error.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
lib/src/editor/raw_editor/quill_single_child_scroll_view.dart |
Replaces deprecated matrix translation call in applyPaintTransform. |
flutter_quill_extensions/analysis_options.yaml |
Adds analyzer config to ignore experimental_member_use in the extensions package. |
example/analysis_options.yaml |
Adds analyzer config to ignore experimental_member_use in the example app. |
.github/workflows/pr-checks.yml |
Marks the analyze-commenter step as non-fatal to avoid fork permission failures failing CI. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+1
to
+5
| include: package:flutter_lints/flutter.yaml | ||
|
|
||
| analyzer: | ||
| errors: | ||
| experimental_member_use: ignore |
Comment on lines
35
to
38
| - if: ${{ !cancelled() }} | ||
| name: Run Flutter Analyze Commenter | ||
| continue-on-error: true | ||
| uses: yorifuji/flutter-analyze-commenter@v1 |
Alspb
added
the
no changelog
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Three pre-existing issues cause every fork PR to fail CI regardless of code quality:
flutter analyzeexits non-zero due toexperimental_member_usewarnings inexample/andflutter_quill_extensions/(intentional use ofpackage:flutter_quill/internal.dart)Matrix4.translatecall inquill_single_child_scroll_view.dartflutter-analyze-commenterfails with "Resource not accessible by integration" on fork PRs — thepull_requesttrigger runs without write access to the base repo, so it can never post a commentChanges description
analysis_options.yamltoexample/andflutter_quill_extensions/suppressingexperimental_member_usewhere usage is deliberate. Rootanalysis_options.yamlis unchanged — the main lib still warns on accidental experimental API use.transform.translate(dx, dy)→transform.translateByDouble(dx, dy, 0, 1)continue-on-error: trueto the commenter step so a permission failure on fork PRs doesn't fail the workflow. The analysis step itself remains strict.Type of Change