fix: prevent toolbar flicker when tapping a checklist checkbox#2747
Open
Alspb wants to merge 1 commit into
Open
fix: prevent toolbar flicker when tapping a checklist checkbox#2747Alspb wants to merge 1 commit into
Alspb wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes a brief toolbar flicker when tapping a checklist checkbox, and retires the internal
QuillController.toolbarButtonTogglerworkaround by deprecating it rather than removing it.Current behavior: Tapping a checklist checkbox also fires the editor's tap gesture (
onSingleTapUp → selectPosition), which moves the caret to the tapped line for one frame. The toolbar briefly reflects that line's style — the header, inline, and color buttons flicker — before_handleCheckboxTap's post-frame restore puts the selection back. The checklist button additionally flashes becauseformatTextstages the checked/unchecked attribute intotoggledStyle, whichgetSelectionStyle()merges.New behavior: The gesture-driven selection change from the checkbox tap is ignored (
_ignoreCheckboxTapSelectionChange), so the caret — and the toolbar — stay put. The checkbox is formatted silently (shouldNotifyListeners: false) so the stagedtoggledStyledoesn't momentarily light up the checklist button; theexisting post-frame
updateSelectionemits a single clean notification.This removes the need for the old
toolbarButtonTogglerworkaround, so its consumers (header buttons/dropdown, checklist button, line-height dropdown) are removed.The field itself is public but undocumented and internal-only; instead of hard-removing it (a breaking change in a minor release), it's kept as a
@Deprecated,@internalno-op and scheduled for removal in a future version.Type of Change