Skip to content

Commit 2482d00

Browse files
Refactor should_interpolate block
1 parent cb6f3ac commit 2482d00

File tree

2 files changed

+12
-12
lines changed

2 files changed

+12
-12
lines changed

singlestoredb/mysql/cursors.py

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@
66
from ..connection import Cursor as BaseCursor
77
from ..utils import results
88
from ..utils.debug import log_query
9+
from ..utils.mogrify import should_interpolate_query
910
from ..utils.results import get_schema
1011

1112
try:
@@ -181,12 +182,7 @@ def mogrify(self, query, args=None):
181182
"""
182183
conn = self._get_db()
183184

184-
if conn.interpolate_query_with_empty_args:
185-
should_interpolate = args is not None
186-
else:
187-
should_interpolate = bool(args)
188-
189-
if should_interpolate:
185+
if should_interpolate_query(conn.interpolate_query_with_empty_args, args):
190186
query = query % self._escape_args(args, conn)
191187

192188
return query

singlestoredb/utils/mogrify.py

Lines changed: 10 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -145,16 +145,20 @@ def mogrify(
145145
str : The query with argument binding applied.
146146
147147
"""
148-
if interpolate_query_with_empty_args:
149-
should_interpolate = args is not None
150-
else:
151-
should_interpolate = bool(args)
152-
153-
if should_interpolate:
148+
if should_interpolate_query(interpolate_query_with_empty_args, args):
154149
query = query % _escape_args(
155150
args, charset=charset,
156151
encoders=encoders,
157152
server_status=server_status,
158153
binary_prefix=binary_prefix,
159154
)
160155
return query
156+
157+
158+
def should_interpolate_query(
159+
interpolate_query_with_empty_args: bool,
160+
args: Union[Sequence[Any], Dict[str, Any], None],
161+
) -> bool:
162+
if interpolate_query_with_empty_args:
163+
return args is not None
164+
return bool(args)

0 commit comments

Comments
 (0)