Fix url

Author: psachdeva-ss

singlestoredb/apps/_config.py

@@ -99,8 +99,6 @@ def from_env(cls) -> 'AppConfig':
             if is_gateway_enabled:
                 base_url = cls._read_variable('SINGLESTOREDB_PYTHON_UDF_BASE_URL')
                 base_path = cls._read_variable('SINGLESTOREDB_PYTHON_UDF_BASE_PATH')
-                assert base_url is not None
-                assert base_path is not None
             else:
                 raise RuntimeError(
                     'Running Python UDFs in interactive mode without nova-gateway enabled is not supported'

singlestoredb/apps/_python_udfs.py

@@ -1,7 +1,5 @@
 import asyncio
-import textwrap
 import typing
-import os
 
 from ._config import PythonUdfAppConfig
 from ._connection_info import ConnectionInfo, PythonUdfConnectionInfo
@@ -16,6 +14,7 @@
 
 
 async def run_udf_app(
+    replace_existing: bool,
     log_level: str = 'error',
     kill_existing_app_server: bool = True,
 ) -> ConnectionInfo:
@@ -40,7 +39,7 @@ async def run_udf_app(
         # Kill if any other process is occupying the port
         kill_process_by_port(app_config.listen_port)
 
-    app = Application()
+    app = Application(url=app_config.base_url)
     app.root_path = app_config.base_path
 
     config = uvicorn.Config(
@@ -51,9 +50,7 @@ async def run_udf_app(
     )
     _running_server = AwaitableUvicornServer(config)
 
-    # In interactive mode this should be set to true
-    replace = app_config.running_interactively
-    app.register_functions(replace=True)
+    app.register_functions(replace=replace_existing)
 
     asyncio.create_task(_running_server.serve())
     await _running_server.wait_for_startup()

singlestoredb/functions/ext/asgi.py

@@ -653,18 +653,6 @@ async def __call__(
         if func_endpoint is not None:
             func, func_info = func_endpoint
 
-        if method == 'GET' and (path == () or path == ""):
-            await send({
-                'type': 'http.response.start',
-                'status': 200,
-                'headers': [(b'content-type', b'text/plain')],
-            })
-            await send({
-                'type': 'http.response.body',
-                'body': b'Server is alive!',
-            })
-            return
-
         # Call the endpoint
         if method == 'POST' and func is not None and path == self.invoke_path:
             data_format = func_info['data_format']
@@ -708,7 +696,7 @@ async def __call__(
             await send(self.text_response_dict)
 
         # Return function info
-        elif method == 'GET' and path == self.show_function_info_path:
+        elif method == 'GET' and (path == "" or path == ()):
             functions = self.get_function_info()
             body = json.dumps(dict(functions=functions)).encode('utf-8')
             await send(self.text_response_dict)
@@ -750,6 +738,7 @@ def _locate_app_functions(self, cur: Any) -> Tuple[Set[str], Set[str]]:
         """Locate all current functions and links belonging to this app."""
         funcs, links = set(), set()
         cur.execute('SHOW FUNCTIONS')
+        print("List Cur", list(cur))
         for name, ftype, _, _, _, link in list(cur):
             # Only look at external functions
             if 'external' not in ftype.lower():