set keep alive probes for mysql connection#122
Conversation
d5a50ad to
7e68f36
Compare
kesmit13
left a comment
There was a problem hiding this comment.
I'm a little concerned about changing a default behavior by this much without a way for the user to change them. These timings are drastically shorter than the defaults. I'm not sure what effect this will have on existing workflows.
@kesmit13 Maybe we can make it configurable just like we do for other setting like This way user could change it if needed. Would you be ok with that? |
should we put this behind a parameter, if user sets |
15ebdc5 to
f0fbf9a
Compare
f0fbf9a to
e840b88
Compare
e840b88 to
fe2855f
Compare
|
This error about dbapi is because the top-level Connection object has a socket_options parameter, so all subclasses must have that specified as well. This would be in |
52eade7 to
a09a161
Compare
a09a161 to
210aeca
Compare
210aeca to
785be45
Compare
Summary
Adding
socket_optionsto configure socket connection for mysql client to allow user to configure specific socket options.Example Use: