Skip to content

fix(requests): fix request params replacement #85

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kesmit13 merged 2 commits into from
Aug 7, 2025
Merged

fix(requests): fix request params replacement #85

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
47ceaab
fix request params replacement
Aug 7, 2025
8ca9d65
fix kwargs
Aug 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions singlestoredb/management/manager.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -148,7 +148,7 @@ def _get(self, path: str, *args: Any, **kwargs: Any) -> requests.Response:

"""
if self._params:
kwargs['params'] = self._params
Comment thread
Rodriguespn marked this conversation as resolved.
kwargs.setdefault('params', {}).update(self._params)
set_organization(kwargs)
return self._check(self._doit('get', path, *args, **kwargs), path, kwargs)

Expand All @@ -171,7 +171,7 @@ def _post(self, path: str, *args: Any, **kwargs: Any) -> requests.Response:

"""
if self._params:
kwargs['params'] = self._params
kwargs.setdefault('params', {}).update(self._params)
set_organization(kwargs)
return self._check(self._doit('post', path, *args, **kwargs), path, kwargs)

Expand All @@ -194,7 +194,7 @@ def _put(self, path: str, *args: Any, **kwargs: Any) -> requests.Response:

"""
if self._params:
kwargs['params'] = self._params
kwargs.setdefault('params', {}).update(self._params)
set_organization(kwargs)
return self._check(self._doit('put', path, *args, **kwargs), path, kwargs)

Expand All @@ -217,7 +217,7 @@ def _delete(self, path: str, *args: Any, **kwargs: Any) -> requests.Response:

"""
if self._params:
kwargs['params'] = self._params
kwargs.setdefault('params', {}).update(self._params)
set_organization(kwargs)
return self._check(self._doit('delete', path, *args, **kwargs), path, kwargs)

Expand All @@ -240,7 +240,7 @@ def _patch(self, path: str, *args: Any, **kwargs: Any) -> requests.Response:

"""
if self._params:
kwargs['params'] = self._params
kwargs.setdefault('params', {}).update(self._params)
set_organization(kwargs)
return self._check(self._doit('patch', path, *args, **kwargs), path, kwargs)

Expand Down