Skip to content

Commit 28efde3

Browse files
authored
Merge pull request #72 from vsbogd/new-contract-version
Upgrade snet-sdk-java to platform-contracts v1.0.1
2 parents abca15a + 560691e commit 28efde3

8 files changed

Lines changed: 15 additions & 32 deletions

File tree

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -144,7 +144,7 @@ execute:
144144
docker run -d \
145145
--name java-sdk-integration-environment \
146146
-p 5002:5002 -p 8545:8545 -p 7000:7000 \
147-
singularitynet/java-sdk-integration-test-env:3.0.0
147+
singularitynet/java-sdk-integration-test-env:5.0.1
148148
```
149149
Then you can run build with integration testing using:
150150
```

integration/tag

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
TAG=3.0.0
1+
TAG=5.0.1

plugin/core/src/test/java/io/singularitynet/sdk/plugin/ServiceApiGetterTest.java

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@
1919
import io.ipfs.api.IPFS;
2020
import io.ipfs.multihash.Multihash;
2121
import org.web3j.protocol.core.RemoteCall;
22-
import org.web3j.tuples.generated.Tuple4;
22+
import org.web3j.tuples.generated.Tuple3;
2323

2424
import io.singularitynet.sdk.common.Utils;
2525
import io.singularitynet.sdk.contracts.Registry;
@@ -45,10 +45,9 @@ public void setUp() throws IOException {
4545
eq(Utils.strToBytes32(SERVICE_ID))))
4646
.thenReturn(new RemoteCall<>(
4747
() -> {
48-
return new Tuple4<>(true,
48+
return new Tuple3<>(true,
4949
Utils.strToBytes32(SERVICE_ID),
50-
Utils.strToBytes("ipfs://" + METADATA_HASH),
51-
Collections.emptyList());
50+
Utils.strToBytes("ipfs://" + METADATA_HASH));
5251
}));
5352

5453
ipfs = mock(IPFS.class);

pom.xml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,13 +12,13 @@
1212
<project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
1313
<maven.compiler.source>1.8</maven.compiler.source>
1414
<maven.compiler.target>1.8</maven.compiler.target>
15-
<platform-contracts.version>1.0.0</platform-contracts.version>
15+
<platform-contracts.version>1.0.1</platform-contracts.version>
1616
<snet-daemon.version>3.0.0</snet-daemon.version>
1717
<protobuf.version>3.5.1</protobuf.version>
1818
<grpc.version>1.28.0</grpc.version>
1919
<web3j.version>4.2.0-android</web3j.version>
2020
<java-sdk-integration-test-env.image>singularitynet/java-sdk-integration-test-env</java-sdk-integration-test-env.image>
21-
<java-sdk-integration-test-env.version>3.0.0</java-sdk-integration-test-env.version>
21+
<java-sdk-integration-test-env.version>5.0.1</java-sdk-integration-test-env.version>
2222
</properties>
2323

2424
<repositories>

sdk/src/main/java/io/singularitynet/sdk/registry/RegistryContract.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@ public RegistryContract(Registry registry) {
3535
public Optional<OrganizationRegistration> getOrganizationById(String orgId) {
3636
return wrapExceptions(() -> {
3737
log.info("Get organization from Registry, orgId: {}", orgId);
38-
Tuple7<Boolean, byte[], byte[], String, List<String>, List<byte[]>, List<byte[]>> result =
38+
Tuple6<Boolean, byte[], byte[], String, List<String>, List<byte[]>> result =
3939
registry.getOrganizationById(strToBytes32(orgId)).send();
4040
if (result.getValue1()) {
4141
OrganizationRegistration.Builder builder = OrganizationRegistration.newBuilder()
@@ -64,7 +64,7 @@ public Optional<OrganizationRegistration> getOrganizationById(String orgId) {
6464
public Optional<ServiceRegistration> getServiceRegistrationById(String orgId, String serviceId) {
6565
return wrapExceptions(() -> {
6666
log.info("Get service from Registry, orgId: {}, serviceId: {}", orgId, serviceId);
67-
Tuple4<Boolean, byte[], byte[], List<byte[]>> result =
67+
Tuple3<Boolean, byte[], byte[]> result =
6868
registry.getServiceRegistrationById(strToBytes32(orgId), strToBytes32(serviceId)).send();
6969
if (result.getValue1()) {
7070
ServiceRegistration registration = ServiceRegistration.newBuilder()

sdk/src/main/java/io/singularitynet/sdk/registry/ServiceRegistration.java

Lines changed: 0 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -3,16 +3,13 @@
33
import lombok.EqualsAndHashCode;
44
import lombok.ToString;
55
import java.net.URI;
6-
import java.util.List;
7-
import java.util.ArrayList;
86

97
@EqualsAndHashCode
108
@ToString
119
public class ServiceRegistration {
1210

1311
private final String serviceId;
1412
private final URI metadataUri;
15-
private final List<String> tags;
1613

1714
public static Builder newBuilder() {
1815
return new Builder();
@@ -25,7 +22,6 @@ public Builder toBuilder() {
2522
private ServiceRegistration(Builder builder) {
2623
this.serviceId = builder.serviceId;
2724
this.metadataUri = builder.metadataUri;
28-
this.tags = builder.tags;
2925
}
3026

3127
public String getServiceId() {
@@ -36,23 +32,17 @@ public URI getMetadataUri() {
3632
return metadataUri;
3733
}
3834

39-
public List<String> getTags() {
40-
return tags;
41-
}
42-
4335
public static class Builder {
4436

4537
private String serviceId;
4638
private URI metadataUri;
47-
private List<String> tags = new ArrayList<>();
4839

4940
private Builder() {
5041
}
5142

5243
private Builder(ServiceRegistration object) {
5344
this.serviceId = object.serviceId;
5445
this.metadataUri = object.metadataUri;
55-
this.tags = object.tags;
5646
}
5747

5848
public Builder setServiceId(String serviceId) {
@@ -65,11 +55,6 @@ public Builder setMetadataUri(URI metadataUri) {
6555
return this;
6656
}
6757

68-
public Builder addTag(String tag) {
69-
this.tags.add(tag);
70-
return this;
71-
}
72-
7358
public ServiceRegistration build() {
7459
return new ServiceRegistration(this);
7560
}

sdk/src/test/java/io/singularitynet/sdk/integration/Web3jTestIT.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@ public void getServiceRegistrationById() throws Exception {
3939
Registry registry = Registry.load(IntEnv.REGISTRY_CONTRACT_ADDRESS.toString(), web3j,
4040
roTransactionManager, gasProvider);
4141

42-
Tuple4<Boolean, byte[], byte[], List<byte[]>> result =
42+
Tuple3<Boolean, byte[], byte[]> result =
4343
registry.getServiceRegistrationById(Utils.strToBytes32(IntEnv.TEST_ORG_ID),
4444
Utils.strToBytes32(IntEnv.TEST_SERVICE_ID)).send();
4545

sdk/src/test/java/io/singularitynet/sdk/registry/RegistryMock.java

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -23,10 +23,10 @@ public void addServiceRegistration(String orgId, String serviceId,
2323
eq(Utils.strToBytes32(serviceId))))
2424
.thenReturn(new RemoteCall<>(
2525
() -> {
26-
return new Tuple4<>(true,
26+
return new Tuple3<>(true,
2727
Utils.strToBytes32(registration.getServiceId()),
28-
Utils.strToBytes(registration.getMetadataUri().toString()),
29-
registration.getTags().stream().map(Utils::strToBytes32).collect(toList()));
28+
Utils.strToBytes(registration.getMetadataUri().toString())
29+
);
3030
})
3131
);
3232
}
@@ -36,13 +36,12 @@ public void addOrganizationRegistration(String orgId,
3636
when(registry.getOrganizationById(eq(Utils.strToBytes32(orgId))))
3737
.thenReturn(new RemoteCall<>(
3838
() -> {
39-
return new Tuple7<>(true,
39+
return new Tuple6<>(true,
4040
Utils.strToBytes32(registration.getOrgId()),
4141
Utils.strToBytes(registration.getMetadataUri().toString()),
4242
"0xfA8a01E837c30a3DA3Ea862e6dB5C6232C9b800A",
4343
Collections.EMPTY_LIST,
44-
registration.getServiceIds().stream().map(Utils::strToBytes32).collect(toList()),
45-
Collections.EMPTY_LIST
44+
registration.getServiceIds().stream().map(Utils::strToBytes32).collect(toList())
4645
);
4746
})
4847
);

0 commit comments

Comments
 (0)