Skip to content

Commit 9311ba6

Browse files
committed
Remove Docker support - focus on Nix-based development
This library uses Nix for development environment management. Docker-based setup added unnecessary complexity for a library package. Removed: - Dockerfile (library packages don't need containerization) - .dockerignore (no longer needed) - .github/docker/Dockerfile.postgres (Nix provides PostgreSQL+pgmq) - .github/workflows/docker-build.yml (no Docker images to build) Updated: - Makefile: Remove all Docker commands, fix project name - SETUP.md: Remove Docker installation method, emphasize Nix - QUICKREF.md: Remove Docker commands section - docs/DEPLOYMENT_GUIDE.md: Simplify Docker reference - scripts/README.md: Fix project name reference Summary: - Removed 368 lines of Docker-related code - Simplified documentation to focus on Nix workflow - Library packages should be added as dependencies, not containerized - Users containerize their own applications, not the library itself Development now uses: - Primary: Nix (recommended - includes everything) - Fallback: Native installation for advanced users
1 parent af769df commit 9311ba6

9 files changed

Lines changed: 17 additions & 368 deletions

File tree

.dockerignore

Lines changed: 0 additions & 61 deletions
This file was deleted.

.github/docker/Dockerfile.postgres

Lines changed: 0 additions & 27 deletions
This file was deleted.

.github/workflows/docker-build.yml

Lines changed: 0 additions & 49 deletions
This file was deleted.

Dockerfile

Lines changed: 0 additions & 96 deletions
This file was deleted.

Makefile

Lines changed: 3 additions & 36 deletions
Original file line numberDiff line numberDiff line change
@@ -1,14 +1,13 @@
1-
.PHONY: help setup test quality clean docker-up docker-down
1+
.PHONY: help setup test quality clean
22

33
# Default target
44
help:
5-
@echo "ExPgflow Development Commands"
6-
@echo "=============================="
5+
@echo "Singularity.Workflow Development Commands"
6+
@echo "=========================================="
77
@echo ""
88
@echo "Setup:"
99
@echo " make setup - Set up development environment (interactive)"
1010
@echo " make setup-nix - Set up using Nix"
11-
@echo " make setup-docker - Set up using Docker (PostgreSQL only)"
1211
@echo ""
1312
@echo "Development:"
1413
@echo " make deps - Install dependencies"
@@ -23,12 +22,6 @@ help:
2322
@echo " make db-reset - Reset database"
2423
@echo " make db-shell - Open PostgreSQL shell"
2524
@echo ""
26-
@echo "Docker:"
27-
@echo " make docker-up - Start PostgreSQL with Docker"
28-
@echo " make docker-down - Stop PostgreSQL"
29-
@echo " make docker-logs - View PostgreSQL logs"
30-
@echo " make docker-reset - Reset Docker environment"
31-
@echo ""
3225
@echo "Formatting & Linting:"
3326
@echo " make format - Format code"
3427
@echo " make lint - Run Credo linter"
@@ -51,9 +44,6 @@ setup:
5144
setup-nix:
5245
@./scripts/setup-dev-environment.sh --method nix
5346

54-
setup-docker:
55-
@./scripts/setup-dev-environment.sh --method docker
56-
5747
# Dependencies
5848
deps:
5949
@echo "Installing dependencies..."
@@ -122,29 +112,6 @@ db-shell:
122112
@echo "Opening PostgreSQL shell..."
123113
@psql $(DATABASE_URL)
124114

125-
# Docker
126-
docker-up:
127-
@echo "Starting PostgreSQL with Docker..."
128-
@docker-compose up -d
129-
@echo "Waiting for PostgreSQL to be ready..."
130-
@sleep 3
131-
@docker-compose exec -T postgres pg_isready -U postgres || (echo "PostgreSQL not ready" && exit 1)
132-
@echo "✓ PostgreSQL is ready"
133-
@echo "Database URL: postgresql://postgres:postgres@localhost:5433/postgres"
134-
135-
docker-down:
136-
@echo "Stopping PostgreSQL..."
137-
@docker-compose down
138-
@echo "✓ PostgreSQL stopped"
139-
140-
docker-logs:
141-
@docker-compose logs -f
142-
143-
docker-reset:
144-
@echo "Resetting Docker environment..."
145-
@docker-compose down -v
146-
@echo "✓ Docker environment reset"
147-
148115
# Documentation
149116
docs:
150117
@echo "Generating documentation..."

QUICKREF.md

Lines changed: 4 additions & 26 deletions
Original file line numberDiff line numberDiff line change
@@ -73,22 +73,6 @@ make db-reset
7373
make db-shell
7474
```
7575

76-
## Docker Commands
77-
78-
```bash
79-
# Start PostgreSQL
80-
make docker-up
81-
82-
# Stop PostgreSQL
83-
make docker-down
84-
85-
# View logs
86-
make docker-logs
87-
88-
# Reset (delete all data)
89-
make docker-reset
90-
```
91-
9276
## Common Tasks
9377

9478
### Running Tests
@@ -159,9 +143,6 @@ make check
159143
# Check PostgreSQL is running
160144
pg_isready -h localhost
161145

162-
# Start PostgreSQL (Docker)
163-
make docker-up
164-
165146
# Reset database
166147
make db-reset
167148
```
@@ -271,10 +252,7 @@ make check
271252
### "pgmq extension not found"
272253

273254
```bash
274-
# Use Docker with pgmq
275-
make docker-up
276-
277-
# Or use Nix
255+
# Use Nix (includes PostgreSQL with pgmq)
278256
nix develop
279257
```
280258

@@ -291,10 +269,10 @@ nix develop
291269
### "Connection refused" (PostgreSQL)
292270

293271
```bash
294-
# Start PostgreSQL
295-
make docker-up
272+
# Use Nix (auto-starts PostgreSQL)
273+
nix develop
296274

297-
# Or check system PostgreSQL
275+
# Or start system PostgreSQL
298276
sudo systemctl start postgresql # Linux
299277
brew services start postgresql # macOS
300278
```

0 commit comments

Comments
 (0)