feat: complete type coverage and enhance CI PostgreSQL setup

- Add @SPEC annotations to all remaining private functions for 100% type coverage
  - orchestrator/config.ex: get_htdag_config, default_config, validate_*
  - workflow_supervisor.ex: ensure_registry_started, default_workflow_name, resolve_repo, repo_from_app
  - orchestrator/repository.ex: maybe_filter_by_workflow, maybe_filter_by_date_range
  - orchestrator.ex: build_task_graph, calculate_task_depths, convert_tasks_to_steps, generate_goal_id
- Fix unused variable warnings (prefix with _)
- Remove duplicate @SPEC annotations
- Enhance CI workflows with PostgreSQL setup:
  - Create main CI workflow (ci.yml) with PostgreSQL 17 + pgmq
  - Add pgmq extension verification to all workflows
  - Ensure proper database setup and health checks
- Achieve zero compilation warnings and errors
- 100% type coverage across all modules

Author: mikkihugo

.github/workflows/ci.yml

@@ -1,27 +1,17 @@
-name: "Copilot Setup Steps"
+name: CI
 
-# Automatically run the setup steps when they are changed to allow for easy validation, and
-# allow manual testing through the repository's "Actions" tab
 on:
-  workflow_dispatch:
   push:
-    paths:
-      - .github/workflows/copilot-setup-steps.yml
+    branches: [main, develop]
   pull_request:
-    paths:
-      - .github/workflows/copilot-setup-steps.yml
+    branches: [main, develop]
+  workflow_dispatch:
 
 jobs:
-  # The job MUST be called `copilot-setup-steps` or it will not be picked up by Copilot.
-  copilot-setup-steps:
+  test:
+    name: Test Suite
     runs-on: ubuntu-latest
 
-    # Set the permissions to the lowest permissions possible needed for your steps.
-    # Copilot will be given its own token for its operations.
-    permissions:
-      # If you want to clone the repository as part of your setup steps, for example to install dependencies, you'll need the `contents: read` permission. If you don't clone the repository in your setup steps, Copilot will do this for you automatically after the steps complete.
-      contents: read
-
     services:
       postgres:
         # Use official pgmq image with PostgreSQL 17 and pgmq pre-installed
@@ -39,8 +29,6 @@ jobs:
         ports:
           - 5432:5432
 
-    # You can define any steps you want, and they will run before the agent starts.
-    # If you do not check out your code, Copilot will do this for you.
     steps:
       - name: Checkout code
         uses: actions/checkout@v4
@@ -51,24 +39,37 @@ jobs:
           elixir-version: '1.19'
           otp-version: '28'
 
-      - name: Restore Elixir dependencies cache
+      - name: Cache Mix dependencies
         uses: actions/cache@v4
         with:
           path: deps
-          key: ${{ runner.os }}-mix-${{ hashFiles('**/mix.lock') }}
-          restore-keys: ${{ runner.os }}-mix-
+          key: ${{ runner.os }}-mix-deps-${{ hashFiles('**/mix.lock') }}
+          restore-keys: |
+            ${{ runner.os }}-mix-deps-
 
-      - name: Install Elixir dependencies
+      - name: Install dependencies
         run: mix deps.get
 
-      - name: Wait for PostgreSQL and create test database
+      - name: Compile
+        run: mix compile --warnings-as-errors
+
+      - name: Wait for PostgreSQL
+        run: |
+          timeout 30 bash -c 'until pg_isready -h localhost -p 5432 -U postgres; do echo "Waiting for PostgreSQL..."; sleep 1; done'
+        env:
+          PGPASSWORD: postgres
+
+      - name: Create test database
         run: |
-          # Wait for PostgreSQL to be ready
-          timeout 30 bash -c 'until pg_isready -h localhost -p 5432 -U postgres; do echo "Waiting for postgres..."; sleep 1; done'
-          sleep 1
+          psql -h localhost -p 5432 -U postgres -tc "SELECT 1 FROM pg_database WHERE datname = 'singularity_workflow_test'" | grep -q 1 || \
+          psql -h localhost -p 5432 -U postgres -c "CREATE DATABASE singularity_workflow_test;"
+        env:
+          PGPASSWORD: postgres
 
-          # Create test database idempotently
-          psql -h localhost -p 5432 -U postgres -tc "SELECT 1 FROM pg_database WHERE datname = 'singularity_workflow_test'" | grep -q 1 || psql -h localhost -p 5432 -U postgres -c "CREATE DATABASE singularity_workflow_test;"
+      - name: Verify pgmq extension
+        run: |
+          psql -h localhost -p 5432 -U postgres -d singularity_workflow_test -c "CREATE EXTENSION IF NOT EXISTS pgmq;"
+          psql -h localhost -p 5432 -U postgres -d singularity_workflow_test -c "SELECT extname, extversion FROM pg_extension WHERE extname = 'pgmq';"
         env:
           PGPASSWORD: postgres
 
@@ -77,3 +78,52 @@ jobs:
         env:
           MIX_ENV: test
           DATABASE_URL: "postgresql://postgres:postgres@localhost:5432/singularity_workflow_test"
+
+      - name: Run tests
+        run: mix test
+        env:
+          MIX_ENV: test
+          DATABASE_URL: "postgresql://postgres:postgres@localhost:5432/singularity_workflow_test"
+
+  quality:
+    name: Code Quality
+    runs-on: ubuntu-latest
+
+    steps:
+      - name: Checkout code
+        uses: actions/checkout@v4
+
+      - name: Set up Elixir
+        uses: erlef/setup-beam@v1
+        with:
+          elixir-version: '1.19'
+          otp-version: '28'
+
+      - name: Cache Mix dependencies
+        uses: actions/cache@v4
+        with:
+          path: deps
+          key: ${{ runner.os }}-mix-deps-${{ hashFiles('**/mix.lock') }}
+          restore-keys: |
+            ${{ runner.os }}-mix-deps-
+
+      - name: Install dependencies
+        run: mix deps.get
+
+      - name: Compile
+        run: mix compile --warnings-as-errors
+
+      - name: Check formatting
+        run: mix format --check-formatted
+
+      - name: Run Credo
+        run: mix credo --strict
+
+      - name: Run Dialyzer
+        run: mix dialyzer --format github
+
+      - name: Run Sobelow
+        run: mix sobelow --exit-on-warning --skip
+
+      - name: Audit dependencies
+        run: mix deps.audit

.github/workflows/comprehensive-ci.yml

@@ -89,6 +89,13 @@ jobs:
       env:
         PGPASSWORD: postgres
 
+    - name: Verify pgmq extension
+      run: |
+        psql -h localhost -p 5432 -U postgres -d singularity_workflow_test -c "CREATE EXTENSION IF NOT EXISTS pgmq;"
+        psql -h localhost -p 5432 -U postgres -d singularity_workflow_test -c "SELECT extname, extversion FROM pg_extension WHERE extname = 'pgmq';"
+      env:
+        PGPASSWORD: postgres
+
     - name: Run migrations
       run: mix ecto.migrate
       env:

.github/workflows/copilot-setup-steps.yml

@@ -97,6 +97,13 @@ jobs:
         env:
           PGPASSWORD: postgres
 
+      - name: Verify pgmq extension
+        run: |
+          psql -h localhost -p 5432 -U postgres -d singularity_workflow_test -c "CREATE EXTENSION IF NOT EXISTS pgmq;"
+          psql -h localhost -p 5432 -U postgres -d singularity_workflow_test -c "SELECT extname, extversion FROM pg_extension WHERE extname = 'pgmq';"
+        env:
+          PGPASSWORD: postgres
+
       - name: Run migrations
         run: |
           export DATABASE_URL="postgresql://postgres:postgres@localhost:5432/singularity_workflow_test"