Revert OCD commit tick.

Revert "Appease VS2010 warning and make ui code more consistent with the modern standard in daeexport.cpp"

This reverts commit cb6dec6.

Author: lkalif

indra/newview/daeexport.cpp

@@ -74,13 +74,16 @@
 // menu includes
 #include "llevent.h"
 #include "llmemberlistener.h"
+#include "llview.h"
 #include "llselectmgr.h"
 
 // Floater and UI
 #include "llfloater.h"
 #include "lluictrlfactory.h"
 #include "llscrollcontainer.h"
 #include "lltexturectrl.h"
+#include "llcombobox.h"
+#include "llcheckboxctrl.h"
 
 // Files and cache
 #include "llcallbacklist.h"
@@ -185,13 +188,16 @@ class ColladaExportFloater
 {
 private:
 	typedef std::map<LLUUID, std::string> texture_list_t;
-	LLView* mExportBtn;
-	LLView* mFileName;
-	LLView* mTextureTypeCombo;
+	LLButton* mExportBtn;
+	LLButton* mBrowseBtn;
+	LLLineEditor* mFileName;
+	LLComboBox* mTextureTypeCombo;
+	LLCheckBoxCtrl* mTextureExportCheck;
 
 	DAESaver mSaver;
 	texture_list_t mTexturesToSave;
 	S32 mTotal;
+	S32 mIncluded;
 	S32 mNumTextures;
 	S32 mNumExportableTextures;
 	std::string mObjectName;
@@ -204,25 +210,16 @@ class ColladaExportFloater
 	{
 		mCommitCallbackRegistrar.add("ColladaExport.FilePicker",		boost::bind(&ColladaExportFloater::onClickBrowse, this));
 		mCommitCallbackRegistrar.add("ColladaExport.Export",			boost::bind(&ColladaExportFloater::onClickExport, this));
-		mCommitCallbackRegistrar.add("ColladaExport.TextureTypeCombo",	boost::bind(&ColladaExportFloater::onTextureTypeCombo, this, boost::bind(&LLUICtrl::getControlName, _1), _2));
-		mCommitCallbackRegistrar.add("ColladaExport.TextureExport",		boost::bind(&ColladaExportFloater::onTextureExportCheck, this, _2));
+		mCommitCallbackRegistrar.add("ColladaExport.TextureTypeCombo",	boost::bind(&ColladaExportFloater::onTextureTypeCombo, this));
+		mCommitCallbackRegistrar.add("ColladaExport.TextureExport",		boost::bind(&ColladaExportFloater::onTextureExportCheck, this));
 		LLUICtrlFactory::getInstance()->buildFloater(this, "floater_dae_export.xml");
 
 		addSelectedObjects();
-		if (LLUICtrl* ctrl = findChild<LLUICtrl>("Object Name"))
-		{
-			ctrl->setTextArg("[NAME]", mObjectName);
-		}
-		if (LLUICtrl* ctrl = findChild<LLUICtrl>("Exportable Prims"))
-		{
-			ctrl->setTextArg("[COUNT]", llformat("%d", mSaver.mObjects.size()));
-			ctrl->setTextArg("[TOTAL]", llformat("%d", mTotal));
-		}
-		if (LLUICtrl* ctrl = findChild<LLUICtrl>("Exportable Textures"))
-		{
-			ctrl->setTextArg("[COUNT]", llformat("%d", mNumExportableTextures));
-			ctrl->setTextArg("[TOTAL]", llformat("%d", mNumTextures));
-		}
+		childSetTextArg("Object Name", "[NAME]", mObjectName);
+		childSetTextArg("Exportable Prims", "[COUNT]", llformat("%d", mIncluded));
+		childSetTextArg("Exportable Prims", "[TOTAL]", llformat("%d", mTotal));
+		childSetTextArg("Exportable Textures", "[COUNT]", llformat("%d", mNumExportableTextures));
+		childSetTextArg("Exportable Textures", "[TOTAL]", llformat("%d", mNumTextures));
 		addTexturePreview();
 	}
 
@@ -236,13 +233,17 @@ class ColladaExportFloater
 
 	BOOL postBuild()
 	{
-		mFileName				= getChildView("file name editor");
-		mExportBtn				= getChildView("export button");
-		mTextureTypeCombo       = getChildView("texture type combo");
+		mFileName				= getChild<LLLineEditor>("file name editor");
+		mExportBtn				= getChild<LLButton>("export button");
+		mBrowseBtn				= getChild<LLButton>("browse button");
+		mTextureTypeCombo       = getChild<LLComboBox>("texture type combo");
+		mTextureExportCheck		= getChild<LLCheckBoxCtrl>("texture export check");
 		mTitleProgress			= getString("texture_progress");
 
+		mExportBtn->setEnabled(FALSE);
+		mFileName->setEnabled(FALSE);
 		mTextureTypeCombo->setValue(gSavedSettings.getS32(mTextureTypeCombo->getControlName()));
-		onTextureExportCheck(getChildView("texture export check")->getValue());
+		onTextureExportCheck();
 		return TRUE;
 	}
 
@@ -252,14 +253,14 @@ class ColladaExportFloater
 		setTitle(mTitleProgress);
 	}
 
-	void onTextureExportCheck(const LLSD& value)
+	void onTextureExportCheck()
 	{
-		mTextureTypeCombo->setEnabled(value);
+		mTextureTypeCombo->setEnabled(mTextureExportCheck->get());
 	}
 
-	void onTextureTypeCombo(const std::string& control_name, const LLSD& value)
+	void onTextureTypeCombo()
 	{
-		gSavedSettings.setS32(control_name, value);
+		gSavedSettings.setS32(mTextureTypeCombo->getControlName(), mTextureTypeCombo->getValue());
 	}
 
 	void onClickBrowse()
@@ -275,7 +276,10 @@ class ColladaExportFloater
 		if (filepicker->hasFilename())
 		{
 			mFileName->setValue(filepicker->getFilename());
-			mExportBtn->setEnabled(TRUE);
+			if (mIncluded > 0)
+			{
+				mExportBtn->setEnabled(TRUE);
+			}
 		}
 	}
 
@@ -306,12 +310,14 @@ class ColladaExportFloater
 			mSaver.mOffset = -selection->getFirstRootObject()->getRenderPosition();
 			mObjectName = selection->getFirstRootNode()->mName;
 			mTotal = 0;
+			mIncluded = 0;
 
 			for (LLObjectSelection::iterator iter = selection->begin(); iter != selection->end(); ++iter)
 			{
 				mTotal++;
 				LLSelectNode* node = *iter;
 				if (!node->getObject()->getVolume() || !DAEExportUtil::canExportNode(node)) continue;
+				mIncluded++;
 				mSaver.add(node->getObject(), node->mName);
 			}
 
@@ -808,7 +814,7 @@ bool DAESaver::saveDAE(std::string filename)
 			v4adapt verts(face->mPositions);
 			v4adapt norms(face->mNormals);
 
-			LLVector2* newCoord = NULL;
+			LLVector2* newCoord;
 
 			if (applyTexCoord)
 			{

indra/newview/skins/default/xui/en-us/floater_dae_export.xml

@@ -2,11 +2,11 @@
 <floater name="Collada Export" title="Collada Export" width="600" height="260" can_close="true" can_minimize="true">
   <string name="texture_progress">Collada Export: Saving textures ([COUNT] remaining)</string>
   <text name="file name" follows="bottom|left" left="10" bottom="-48" height="20">File Name:</text>
-  <line_editor name="file name editor" follows="bottom|left" left_delta="60" bottom_delta="4" width="360" height="20" enabled="false"/>
+  <line_editor name="file name editor" follows="bottom|left" left_delta="60" bottom_delta="4" width="360" height="20"/>
   <button name="browse button" label="Browse" follows="bottom|left" left_delta="363" bottom_delta="0" width="80" height="20">
     <button.commit_callback function="ColladaExport.FilePicker"/>
   </button>
-  <button name="export button" label="Export" follows="bottom|left" left_delta="83" bottom_delta="0" width="80" height="20" enabled="false">
+  <button name="export button" label="Export" follows="bottom|left" left_delta="83" bottom_delta="0" width="80" height="20">
     <button.commit_callback function="ColladaExport.Export"/>
   </button>
   <panel border="true" left="10" bottom_delta="-88" height="80" width="200" follows="bottom|left" name="object info panel">