changing generation of timestamp and defaults

Author: vsoch

CHANGELOG.md

@@ -0,0 +1,20 @@
+# CHANGELOG
+
+This is a manually generated log to track changes to the repository for each release. 
+Each section should include general headers such as **Implemented enhancements** 
+and **Merged pull requests**. All closed issued and bug fixes should be 
+represented by the pull requests that fixed them. This log originated with Singularity 2.4
+and changes prior to that are (unfortunately) done retrospectively. Critical items to know are:
+
+ - renamed commands
+ - deprecated / removed commands
+ - changed defaults
+ - backward incompatible changes (recipe file format? image file format?)
+ - migration guidance (how to convert images?)
+ - changed behaviour (recipe sections work differently)
+
+
+## [vxx](https://github.com/singularityware/singularity-python/tree/development) (development)
+
+**changed defaults**
+ - *sregistry client*: to support use of squashfs images and singularity 2.4, the default upload is not compressed, assuming squashfs, and the default download is not decompressed. To still compress an image add the `--compress` flag on push, and the `--decompress` flag on pull.

README.md

@@ -4,7 +4,7 @@
 
 Singularity Python is a python module and command line tool for working with <a href="https://singularityware.github.io" target="_blank">Singularity</a> containers, specifically providing functions to visualize, package, and compare containers. Currently, most functions use Singularity on the command line, and some require sudo.
 
-We currently require Python > version 3 to use various timezone functions. If you are unable to install version 3.0, we provide a [Singularity.container](Singularity.container) for you to use instead. See the [installation docs](https://github.com/singularityware/singularity-python/wiki/Installation) for your different options.
+We currently require Python > version 3 to use various timezone functions. If you are unable to install version 3.0, we provide a [Singularity.container](Singularity.container) for you to use instead. This is the recommended approach as some older versions of Python do not support generation of the timestamp. See the [installation docs](https://github.com/singularityware/singularity-python/wiki/Installation) for your different options.
 
 The Singularity-Python code is licensed under the MIT open source license, which is a highly permissive license that places few limits upon reuse. This ensures that the code will be usable by the greatest number of researchers, in both academia and industry. The following examples are provided:
 

singularity/registry/auth.py

@@ -61,8 +61,7 @@ def generate_signature(payload, secret):
 
 
 def generate_timestamp():
-    ts = datetime.now()
-    ts = ts.replace(tzinfo=timezone.utc)
+    ts = datetime.now(timezone.utc)
     return ts.strftime('%Y%m%dT%HZ')
 
 

singularity/registry/client/push.py

@@ -50,7 +50,7 @@
 )
 
 
-def push(self, path, name, tag=None, compress=True):
+def push(self, path, name, tag=None, compress=False):
     '''push an image to Singularity Registry'''
 
     path = os.path.abspath(path)

singularity/registry/main/__init__.py

@@ -97,8 +97,8 @@ def get_parser():
                        help='name of image, in format "library/image"', 
                        type=str, required=True)
 
-    push.add_argument('--no-compress', dest="nocompress", 
-                      help="show the test for each container.", 
+    push.add_argument('--compress', dest="compress", 
+                      help="compress the container on upload (for legacy containers prior to 2.4)", 
                       default=False, action='store_true')
 
 
@@ -114,8 +114,8 @@ def get_parser():
                        help='custom name for image', 
                        type=str, default=None)
 
-    pull.add_argument('--no-decompress', dest="nodecompress", 
-                      help="extract a gzip compressed image", 
+    pull.add_argument('--decompress', dest="decompress", 
+                      help="extract a gzip compressed image for legacy (prior to 2.4) containers", 
                       default=False, action='store_true')
 
     # List or search labels

singularity/registry/main/pull.py

@@ -35,4 +35,4 @@ def main(args,parser,subparser):
     sreg = Client(secrets=args.secrets)
     response = sreg.pull(images=args.image,
                          file_name=args.name,
-                         decompress=not args.nodecompress)
+                         decompress=args.decompress)

singularity/registry/main/push.py

@@ -44,6 +44,4 @@ def main(args,parser,subparser):
     response = sreg.push(path=image,
                          name=args.name,
                          tag=args.tag,
-                         compress=not args.nocompress)
-
-
+                         compress=args.compress)