Skip to content

fix(task-new): remove dataset max rows limit#44

Merged
singyichen merged 7 commits into
mainfrom
fix/remove-dataset-max-rows-limit
May 12, 2026
Merged

fix(task-new): remove dataset max rows limit#44
singyichen merged 7 commits into
mainfrom
fix/remove-dataset-max-rows-limit

Conversation

@singyichen

@singyichen singyichen commented May 11, 2026

Copy link
Copy Markdown
Owner

Summary

  • Remove the hardcoded DATASET_MAX_ROWS constraint from the task creation spec and prototype copy.
  • Align task detail, task list, annotation list, and annotation workspace prototype states around run materialization and dry-run context.
  • Expand prototype Playwright coverage for task detail profiles and task list run materialization cues.

Why

Task creation should not expose or enforce a fixed dataset row ceiling in the prototype/spec. The related prototype states also needed to stay coherent once task runs have or have not materialized annotation lists.

Validation

  • pnpm playwright test tests/task-management/task-detail-task-profiles.spec.ts tests/task-management/task-list-run-materialization.spec.ts from design/prototype/ passed: 26 passed.

Notes

  • gh auth status reports the local gh token for singyichen is invalid, so this PR was created through the GitHub connector.

Review Resolutions

Round 1 — 2026-05-12

  • design/prototype/pages/task-management/task-detail.html: confirmed T006 exists in TASK_PROFILE_MAP for the NER task profile.
  • design/prototype/pages/task-management/task-list.html: confirmed T006, T007, T009, and T010 exist in CREATED_TASKS_SEED.
  • design/prototype/pages/annotation/annotation-list.html: preserved materialized zero totals and moved list count labels to i18n templates.
  • design/prototype/pages/annotation/annotation-workspace.html: preserved materialized zero totals in the workspace sample list header.
  • design/prototype/tests/task-management/task-list-run-materialization.spec.ts: added zero-count materialization regression coverage for list and workspace views.

singyichen and others added 3 commits May 8, 2026 17:06
…ation gates, context management, and source-verify gate

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…type

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-authored-by: OpenAI Codex <noreply@openai.com>

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request implements "run materialization" for annotation tasks, ensuring that sample lists are generated only during specific publish events (trial rounds or official runs) rather than at task creation. Key changes include updating the task detail and list pages to handle new run stages, adding trial round metadata to the annotation workspace, and updating project specifications and Playwright tests to reflect these workflow changes. Feedback focuses on inconsistencies between the prototype's seed data and the new test cases (specifically missing tasks like T006), logic errors when handling zero-count samples in the materialized context, and suggestions for better localization consistency across pages.

Comment thread design/prototype/pages/task-management/task-detail.html
Comment thread design/prototype/pages/task-management/task-list.html
Comment thread design/prototype/pages/annotation/annotation-list.html Outdated
Comment thread design/prototype/pages/annotation/annotation-list.html Outdated
Comment thread design/prototype/pages/annotation/annotation-workspace.html Outdated

@amazon-q-developer amazon-q-developer Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR successfully delivers the annotation workspace, task detail, and task creation prototypes along with their specifications and test scenarios. The prototypes are well-structured HTML demonstrations stored appropriately in design/prototype/pages/.

All files reviewed are design artifacts and specifications - no production code changes are included. The prototypes use placeholder credentials which is appropriate for design demonstrations. The spec documents are comprehensive and the test scenarios provide clear acceptance criteria.

No blocking issues identified. The PR is ready to merge.


You can now have the agent implement changes and create commits directly on your pull request's source branch. Simply comment with /q followed by your request in natural language to ask the agent to make changes.

singyichen and others added 4 commits May 12, 2026 08:54
Co-authored-by: OpenAI Codex <noreply@openai.com>
Co-authored-by: OpenAI Codex <noreply@openai.com>
Co-authored-by: OpenAI Codex <noreply@openai.com>
Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>
@singyichen singyichen marked this pull request as ready for review May 12, 2026 02:36
@qodo-code-review

Copy link
Copy Markdown
ⓘ You've reached your Qodo monthly free-tier limit. Reviews pause until next month — upgrade your plan to continue now, or link your paid account if you already have one.

@singyichen singyichen merged commit f1badf6 into main May 12, 2026
8 checks passed
@singyichen singyichen deleted the fix/remove-dataset-max-rows-limit branch May 12, 2026 02:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant