fix(task-new): remove dataset max rows limit#44
Conversation
…ation gates, context management, and source-verify gate Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…type Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-authored-by: OpenAI Codex <noreply@openai.com>
There was a problem hiding this comment.
Code Review
This pull request implements "run materialization" for annotation tasks, ensuring that sample lists are generated only during specific publish events (trial rounds or official runs) rather than at task creation. Key changes include updating the task detail and list pages to handle new run stages, adding trial round metadata to the annotation workspace, and updating project specifications and Playwright tests to reflect these workflow changes. Feedback focuses on inconsistencies between the prototype's seed data and the new test cases (specifically missing tasks like T006), logic errors when handling zero-count samples in the materialized context, and suggestions for better localization consistency across pages.
There was a problem hiding this comment.
This PR successfully delivers the annotation workspace, task detail, and task creation prototypes along with their specifications and test scenarios. The prototypes are well-structured HTML demonstrations stored appropriately in design/prototype/pages/.
All files reviewed are design artifacts and specifications - no production code changes are included. The prototypes use placeholder credentials which is appropriate for design demonstrations. The spec documents are comprehensive and the test scenarios provide clear acceptance criteria.
No blocking issues identified. The PR is ready to merge.
You can now have the agent implement changes and create commits directly on your pull request's source branch. Simply comment with /q followed by your request in natural language to ask the agent to make changes.
Co-authored-by: OpenAI Codex <noreply@openai.com>
Co-authored-by: OpenAI Codex <noreply@openai.com>
Co-authored-by: OpenAI Codex <noreply@openai.com>
Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>
ⓘ You've reached your Qodo monthly free-tier limit. Reviews pause until next month — upgrade your plan to continue now, or link your paid account if you already have one. |
Summary
DATASET_MAX_ROWSconstraint from the task creation spec and prototype copy.Why
Task creation should not expose or enforce a fixed dataset row ceiling in the prototype/spec. The related prototype states also needed to stay coherent once task runs have or have not materialized annotation lists.
Validation
pnpm playwright test tests/task-management/task-detail-task-profiles.spec.ts tests/task-management/task-list-run-materialization.spec.tsfromdesign/prototype/passed: 26 passed.Notes
gh auth statusreports the localghtoken forsingyichenis invalid, so this PR was created through the GitHub connector.Review Resolutions
Round 1 — 2026-05-12
design/prototype/pages/task-management/task-detail.html: confirmedT006exists inTASK_PROFILE_MAPfor the NER task profile.design/prototype/pages/task-management/task-list.html: confirmedT006,T007,T009, andT010exist inCREATED_TASKS_SEED.design/prototype/pages/annotation/annotation-list.html: preserved materialized zero totals and moved list count labels to i18n templates.design/prototype/pages/annotation/annotation-workspace.html: preserved materialized zero totals in the workspace sample list header.design/prototype/tests/task-management/task-list-run-materialization.spec.ts: added zero-count materialization regression coverage for list and workspace views.