Skip to content

fix: align restoreObject docs test with idempotent behavior #2745

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hexeberlin merged 1 commit into from
Jul 20, 2026
+5 −7
Merged

fix: align restoreObject docs test with idempotent behavior #2745

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions docs/concepts/utils.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,8 +23,8 @@ Restores all methods of an object and returns the restored object.

<<< ../.vitepress/tests/docs/utils-2.test.js

Throws an error if the object contains no restorable methods (spies, stubs, etc).
Does nothing if the object contains no restorable methods (spies, stubs, etc).

<<< ../.vitepress/tests/docs/utils-3.test.js

Throws an error if the object contains no restorable methods (spies, stubs, etc).
Does nothing if the object contains no restorable methods (spies, stubs, etc).
8 changes: 3 additions & 5 deletions docs/tests/docs/utils-3.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,14 +1,12 @@
import t from "tap";
import sinon from "sinon";

t.test("restoreObject throws when object has no restorable methods", (t) => {
t.test("restoreObject is a no-op when object has no restorable methods", (t) => {
const emptyObj = {};

// Verify it throws an error
t.throws(
t.doesNotThrow(
() => sinon.restoreObject(emptyObj),
/no methods/i,
"should throw error about no methods to restore"
"should be a no-op when object has no restorable methods"
);

t.end();
Expand Down
Loading