RTPChannel: log failure to send

Author: lostmsu

src/net/RTP/RTPChannel.cs

@@ -157,7 +157,7 @@ public virtual void BeginReceiveFrom()
                         {
                             EndReceiveFrom(excp);
                         }
-                    });
+                    }).Forget(logger);
                 }
 #else
                 m_socket.BeginReceiveFrom(m_recvBuffer, 0, m_recvBuffer.Length, SocketFlags.None, ref recvEndPoint, endReceiveFrom, null);
@@ -620,6 +620,7 @@ public virtual SocketError Send(RTPChannelSocketsEnum sendOn, IPEndPoint dstEndP
                     }
                     if (send.IsCompleted)
                     {
+                        ArrayPool<byte>.Shared.Return(tmp);
                         try
                         {
                             send.GetAwaiter().GetResult();
@@ -628,10 +629,6 @@ public virtual SocketError Send(RTPChannelSocketsEnum sendOn, IPEndPoint dstEndP
                         {
                             EndSendTo(excp, dstEndPoint, sendSocket, onFailure);
                         }
-                        finally
-                        {
-                            ArrayPool<byte>.Shared.Return(tmp);
-                        }
                     }
                     else
                     {
@@ -642,7 +639,7 @@ public virtual SocketError Send(RTPChannelSocketsEnum sendOn, IPEndPoint dstEndP
                             {
                                 EndSendTo(t.Exception, dstEndPoint, sendSocket, onFailure);
                             }
-                        });
+                        }).Forget(logger);
                     }
 
 #else

src/sys/TaskExtensions.cs

@@ -0,0 +1,20 @@
+using System;
+using System.Threading.Tasks;
+using Microsoft.Extensions.Logging;
+
+namespace SIPSorcery;
+
+static class TaskExtensions
+{
+    public static async void Forget(this Task task, ILogger logger)
+    {
+        try
+        {
+            await task.ConfigureAwait(false);
+        }
+        catch (Exception ex)
+        {
+            logger.LogDebug(ex, "An unhandled exception occurred in a fire-and-forget task.");
+        }
+    }
+}