Add unit tests for RTSPHeader.SplitHeaders line folding#1657
Merged
Conversation
SplitHeaders performs RTSP header line-folding (collapsing continuation lines that begin with whitespace) and normalisation of malformed carriage-return line endings, but had no direct test coverage; it was only exercised indirectly via well-formed round-trip messages. These characterisation tests lock in the existing behaviour: - basic CRLF-separated splitting - continuation line folded with a leading space - continuation line folded with a leading tab - lone "\r " (CR + space) treated as a line break Verified to pass against both the current regex-based implementation and the span-based rewrite in #1654, confirming the two are equivalent. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
RTSPHeader.SplitHeadersperforms RTSP header line folding (collapsing continuation lines that begin with whitespace onto the previous line) and normalises malformed\r(CR + space) line endings. Despite being non-trivial parsing logic, it had no direct test coverage — it was only exercised indirectly through well-formed round-trip messages.This PR adds four characterisation tests for it:
"\r "(CR + space) treated as a proper line breakWhy now
#1654 rewrites
SplitHeadersto replace theRegexcalls with a hand-rolled span-based normaliser. That's the kind of change where a behavioural regression could slip through silently, since the only existing RTSP test uses well-formed input that never folds.I verified these tests pass against both:
masterregex-based implementation, and…which confirms the two implementations are equivalent for these cases. The tests are written against
masterso they guard the behaviour regardless of whether/when #1654 lands.Test plan
Passed: 4/4 on both branches.
🤖 Generated with Claude Code