Skip to content

Commit 3f09ce1

Browse files
author
Gonzalo Diaz
committed
[BUGFIX] Many issues "If memory allocation fails, then there is a possible null pointer dereference:" fixed.
1 parent 1d6cf1e commit 3f09ce1

4 files changed

Lines changed: 14 additions & 0 deletions

File tree

src/lib/exercises/src/hackerrank/warmup/mini_max_sum.c

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -37,6 +37,10 @@ char *HACKERRANK_WARMUP_miniMaxSumCalculate(int arr_count, const int *arr) {
3737

3838
void HACKERRANK_WARMUP_miniMaxSum(int arr_count, const int *arr) {
3939
char *result = HACKERRANK_WARMUP_miniMaxSumCalculate(arr_count, arr);
40+
if (result == NULL) {
41+
return;
42+
}
43+
4044
printf("%s\n", result);
4145
free(result);
4246
}

src/lib/exercises/src/hackerrank/warmup/plus_minus.c

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -73,6 +73,9 @@ void HACKERRANK_WARMUP_freePlusMinus(char **plusMinusAnswer, int n) {
7373

7474
void HACKERRANK_WARMUP_plusMinus(int arr_count, const int *arr) {
7575
char **output = HACKERRANK_WARMUP_plusMinusCalculate(arr_count, arr);
76+
if (output == NULL) {
77+
return;
78+
}
7679

7780
for (int i = 0; i < HACKERRANK_WARMUP_PLUSMINUS_LIMIT_ANSWERS; i++) {
7881
printf("%s", output[i]);

src/lib/exercises/src/hackerrank/warmup/staircase.c

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -45,6 +45,9 @@ void HACKERRANK_WARMUP_freeStaircase(char **staircase, int n) {
4545

4646
void HACKERRANK_WARMUP_staircase(int n) {
4747
char **output = HACKERRANK_WARMUP_staircaseCalculate(n);
48+
if (output == NULL) {
49+
return;
50+
}
4851

4952
for (int i = 0; i < n; i++) {
5053
printf("%s\n", output[i]);

src/lib/exercises/src/hackerrank/warmup/time_conversion.c

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -54,6 +54,10 @@ char *HACKERRANK_WARMUP_timeConversion(const char *s) {
5454
char *conversion =
5555
malloc((HACKERRANK_WARMUP_SHORT_TIME_FORMAT_SIZE + 1) * sizeof(char));
5656

57+
if (conversion == NULL) {
58+
return NULL;
59+
}
60+
5761
for (int i = 0; i < HACKERRANK_WARMUP_SHORT_TIME_FORMAT_SIZE; i++) {
5862
conversion[i] = s[i];
5963
}

0 commit comments

Comments
 (0)