Skip to content

[REFACTOR] logging functions moved to their own package for "clean co… #329

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sir-gon merged 2 commits into from
Apr 23, 2025
Merged

[REFACTOR] logging functions moved to their own package for "clean co… #329

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
722f9ce
[REFACTOR] logging functions moved to their own package for "clean co…
Apr 23, 2025
589f707
[REFACTOR] [BUGFIX] Codefactor: Redefinition of the built-in function…
Apr 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions exercises/hackerrank/warmup/aVeryBigSum.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,7 @@

package hackerrank

import (
utils "gon.cl/algorithms/utils"
)
import "gon.cl/algorithms/utils/log"

func AVeryBigSum(ar []uint64) uint64 {
var result uint64 = 0
Expand All @@ -15,6 +13,6 @@ func AVeryBigSum(ar []uint64) uint64 {
result += ar[i]
}

utils.Info("aVeryBigSum answer => %d", result)
log.Info("aVeryBigSum answer => %d", result)
return result
}
4 changes: 2 additions & 2 deletions exercises/hackerrank/warmup/compareTriplets.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ package hackerrank
import (
"errors"

utils "gon.cl/algorithms/utils"
"gon.cl/algorithms/utils/log"
)

func CompareTriplets(a []int, b []int) ([]int, error) {
Expand All @@ -27,7 +27,7 @@ func CompareTriplets(a []int, b []int) ([]int, error) {
}
}

utils.Info("SolveMeFirst answer => %v", awards)
log.Info("SolveMeFirst answer => %v", awards)

return awards, nil
}
6 changes: 3 additions & 3 deletions exercises/hackerrank/warmup/diagonalDifference.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ package hackerrank
import (
"math"

utils "gon.cl/algorithms/utils"
"gon.cl/algorithms/utils/log"
)

func DiagonalDifference(arr [][]int) int {
Expand All @@ -24,8 +24,8 @@ func DiagonalDifference(arr [][]int) int {
}
}

utils.Info("diag1 => %d", diag1)
utils.Info("diag2 => %d", diag2)
log.Info("diag1 => %d", diag1)
log.Info("diag2 => %d", diag2)

return int(math.Abs(float64(diag1 - diag2)))
}
4 changes: 2 additions & 2 deletions exercises/hackerrank/warmup/plusMinus.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ import (
"fmt"
"strings"

utils "gon.cl/algorithms/utils"
"gon.cl/algorithms/utils/log"
)

func PlusMinus(arr []int) string {
Expand Down Expand Up @@ -37,7 +37,7 @@ func PlusMinus(arr []int) string {

answer := strings.Join(result, "\n")

utils.Info("PlusMinus answer => %s", answer)
log.Info("PlusMinus answer => %s", answer)

return answer
}
6 changes: 2 additions & 4 deletions exercises/hackerrank/warmup/simpleArraySum.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,7 @@

package hackerrank

import (
utils "gon.cl/algorithms/utils"
)
import "gon.cl/algorithms/utils/log"

func SimpleArraySum(arr []int) int {
acum := 0
Expand All @@ -15,7 +13,7 @@ func SimpleArraySum(arr []int) int {
acum += arr[i]
}

utils.Info("SimpleArraySum answer => %d", acum)
log.Info("SimpleArraySum answer => %d", acum)

return acum
}
6 changes: 2 additions & 4 deletions exercises/hackerrank/warmup/solveMeFirst.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,15 +4,13 @@

package hackerrank

import (
utils "gon.cl/algorithms/utils"
)
import "gon.cl/algorithms/utils/log"

func SolveMeFirst(a int, b int) int {

var answer = a + b

utils.Info("SolveMeFirst answer => %d", answer)
log.Info("SolveMeFirst answer => %d", answer)

return answer
}
4 changes: 2 additions & 2 deletions exercises/hackerrank/warmup/staircase.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ package hackerrank
import (
"strings"

utils "gon.cl/algorithms/utils"
"gon.cl/algorithms/utils/log"
)

func Staircase(n int) string {
Expand All @@ -28,7 +28,7 @@ func Staircase(n int) string {
result = append(result, line)
}

utils.Info("Staircase answer => %v", result)
log.Info("Staircase answer => %v", result)

return strings.Join(result, "\n")
}
4 changes: 2 additions & 2 deletions exercises/hackerrank/warmup/timeConversion.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ import (
"strconv"
"strings"

utils "gon.cl/algorithms/utils"
"gon.cl/algorithms/utils/log"
)

func TimeConversion(s string) string {
Expand All @@ -32,7 +32,7 @@ func TimeConversion(s string) string {

conversion := strings.Join(time, ":")

utils.Info("TimeConversion answer => %s", conversion)
log.Info("TimeConversion answer => %s", conversion)

return conversion
}
6 changes: 2 additions & 4 deletions exercises/problem0000.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,15 +4,13 @@

package exercises

import (
utils "gon.cl/algorithms/utils"
)
import "gon.cl/algorithms/utils/log"

func Problem0000() int {

var answer int

utils.Info("Problem0000 answer => %d", answer)
log.Info("Problem0000 answer => %d", answer)

return answer
}
8 changes: 4 additions & 4 deletions exercises/projecteuler/helpers/divisors.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ import (
"math"
"sort"

"gon.cl/algorithms/utils"
"gon.cl/algorithms/utils/log"
)

type Factor struct {
Expand All @@ -28,7 +28,7 @@ func Divisors(target int) []int {
return divs
}

utils.Debug("Find divisors of %d", target)
log.Debug("Find divisors of %d", target)

// fast divisors finding loop
i := int(2)
Expand All @@ -50,11 +50,11 @@ func Divisors(target int) []int {
}

divs = append(divs, target)
utils.Debug("collected divisors %x", divs)
log.Debug("collected divisors %x", divs)

// sort divisors
sort.Slice(divs, func(i, j int) bool { return divs[i] < divs[j] })
utils.Debug("sorted divisors %x", divs)
log.Debug("sorted divisors %x", divs)

return divs
}
Expand Down
6 changes: 3 additions & 3 deletions exercises/projecteuler/helpers/numberToWord.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ import (
"fmt"
"math/big"

"gon.cl/algorithms/utils"
"gon.cl/algorithms/utils/log"
)

const _CENTS_ = "hundred"
Expand Down Expand Up @@ -70,7 +70,7 @@ func NumberToWord(value big.Int) (string, bool) {
dec, unit = dec.DivMod(&value, div, unit)
dec = dec.Mul(dec, big.NewInt((10)))

utils.Debug("dec => %s | div => %s | unit => %s",
log.Debug("dec => %s | div => %s | unit => %s",
dec.Text(__NUMERIC_BASE__),
div.Text(__NUMERIC_BASE__),
unit.Text(__NUMERIC_BASE__),
Expand All @@ -96,7 +96,7 @@ func NumberToWord(value big.Int) (string, bool) {
}

last, err := NumberToWord(*rest)
utils.Debug("err => %t", err) // in bounds, never happens
log.Debug("err => %t", err) // in bounds, never happens

return fmt.Sprintf("%s %s and %s",
dictionary[cent.Text(__NUMERIC_BASE__)],
Expand Down
6 changes: 2 additions & 4 deletions exercises/projecteuler/helpers/wordScore.go
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,6 @@
package helpers

import (
"gon.cl/algorithms/utils"
)
import "gon.cl/algorithms/utils/log"

var _scoreLetter = map[rune]int{
'A': 1,
Expand Down Expand Up @@ -38,7 +36,7 @@ func WordScore(word string) int {
count := 0

for i, c := range word {
utils.Debug("%d => %c", i, c)
log.Debug("%d => %c", i, c)

score, exist := _scoreLetter[c]

Expand Down
10 changes: 5 additions & 5 deletions exercises/projecteuler/lib/BNodeBuilder.go
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
package lib

import "gon.cl/algorithms/utils"
import "gon.cl/algorithms/utils/log"

func buildBNodeTreeRecursive(
dataTree [][]int,
Expand All @@ -16,12 +16,12 @@ func buildBNodeTreeRecursive(
i+1 <= len(dataTree)-1 && j+1 <= len(dataTree[i+1])-1 {

left, err := buildBNodeTreeRecursive(dataTree, i+1, j)
utils.Debug("left: %v | err: %t", left, err)
log.Debug("left: %v | err: %t", left, err)

resultNode.setLeft(left)

right, err := buildBNodeTreeRecursive(dataTree, i+1, j+1)
utils.Debug("right: %v | err: %t", left, err)
log.Debug("right: %v | err: %t", left, err)

resultNode.setRight(right)

Expand Down Expand Up @@ -55,12 +55,12 @@ func buildBNodeTreeWeigthRecursive(
var err bool

left, leafCollector, err = buildBNodeTreeWeigthRecursive(dataTree, i+1, j, resultNode, leafCollector)
utils.Debug("left: %v | err: %t | leavesCarry: %v", left, err, leafCollector)
log.Debug("left: %v | err: %t | leavesCarry: %v", left, err, leafCollector)

resultNode.setLeft(left)

right, leafCollector, err = buildBNodeTreeWeigthRecursive(dataTree, i+1, j+1, resultNode, leafCollector)
utils.Debug("right: %v | err: %t | leavesCarry: %v", left, err, leafCollector)
log.Debug("right: %v | err: %t | leavesCarry: %v", left, err, leafCollector)

resultNode.setRight(right)

Expand Down
6 changes: 3 additions & 3 deletions exercises/projecteuler/problem0001.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
package projecteuler

import (
utils "gon.cl/algorithms/utils"
"gon.cl/algorithms/utils/log"
)

func Problem0001(top int) int {
Expand All @@ -16,11 +16,11 @@ func Problem0001(top int) int {

total += i

utils.Debug("Problem0001: STEP: %d => TOTAL: %d", i, total)
log.Debug("Problem0001: STEP: %d => TOTAL: %d", i, total)
}
}

utils.Info("Problem0001 result: %d", total)
log.Info("Problem0001 result: %d", total)

return total
}
6 changes: 3 additions & 3 deletions exercises/projecteuler/problem0002.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
package projecteuler

import (
utils "gon.cl/algorithms/utils"
"gon.cl/algorithms/utils/log"
)

func Problem0002(top int) int {
Expand All @@ -20,7 +20,7 @@ func Problem0002(top int) int {
for ok := true; ok; ok = fibo < top {
fibo = last2 + last1

utils.Debug("Fibonacci (%d) = %d", i, fibo)
log.Debug("Fibonacci (%d) = %d", i, fibo)

// acumulate sum of event terms
if fibo%2 == 0 {
Expand All @@ -33,7 +33,7 @@ func Problem0002(top int) int {
i += 1
}

utils.Info("Problem0002 result: %d", evenSum)
log.Info("Problem0002 result: %d", evenSum)

return evenSum
}
8 changes: 4 additions & 4 deletions exercises/projecteuler/problem0003.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,22 +6,22 @@ package projecteuler

import (
"gon.cl/algorithms/exercises/projecteuler/helpers"
utils "gon.cl/algorithms/utils"
"gon.cl/algorithms/utils/log"
)

func Problem0003(top int) int {
var maxPrimeFactor int

divs := helpers.Divisors(top)

utils.Info("Divisors(%d) = %v \n", top, divs)
log.Info("Divisors(%d) = %v \n", top, divs)

var i = len(divs) - 1

for ok := true; ok; ok = i >= 0 && maxPrimeFactor == 0 {
prime := helpers.IsPrime(divs[i])

utils.Debug("%d is Prime? => %t \n", divs[i], prime)
log.Debug("%d is Prime? => %t \n", divs[i], prime)

if prime {
maxPrimeFactor = divs[i]
Expand All @@ -30,7 +30,7 @@ func Problem0003(top int) int {
i -= 1
}

utils.Info("maxPrimeFactor is %d \n", maxPrimeFactor)
log.Info("maxPrimeFactor is %d \n", maxPrimeFactor)

return maxPrimeFactor
}
Loading