Skip to content

AI driven upgrade of eslint 8.x to 9.x #851

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sir-gon merged 3 commits into from
Jan 6, 2026
Merged

AI driven upgrade of eslint 8.x to 9.x #851

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d6b8f82
AI driven upgrade of eslint 8.x to 9.x
Jan 6, 2026
2b1f6a4
[CONFIG] [Github Actions] AI driven upgrade of eslint 8.x to 9.x
Jan 6, 2026
3ac64fb
[CONFIG] [Docker] AI driven upgrade of eslint 8.x to 9.x
Jan 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions .github/workflows/eslint-code-scanning.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,10 +50,10 @@ jobs:
with:
node-version: 24.x

- name: Install ESLint
- name: Install dependencies
run: |
npm install --include=dev eslint@8.57.1
npm install --include=dev @microsoft/eslint-formatter-sarif@3.0.0
npm ci --legacy-peer-deps
npm install --legacy-peer-deps @microsoft/eslint-formatter-sarif@3.0.0

- name: Test ESLint
run: |
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/eslint.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,9 +45,9 @@ jobs:
with:
node-version: ${{ matrix.node-version }}

- name: Install ESLint
- name: Install dependencies
run: |
npm install --include=dev eslint@8.57.1
npm ci --legacy-peer-deps

- name: Test ESLint
run: |
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/node-coverage.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ jobs:
node-version: 24.x

- name: Install dependencies
run: npm ci --verbose
run: npm ci --legacy-peer-deps

- name: Lint
run: npm run lint
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/node-test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ jobs:
node-version: ${{ matrix.node-version }}

- name: Install dependencies
run: npm ci --verbose
run: npm ci --legacy-peer-deps

- name: Run the tests
run: npm run jest:ci
4 changes: 2 additions & 2 deletions Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ COPY ./.yamlignore ${WORKDIR}/
COPY ./.gitignore ${WORKDIR}/

# Dependencies
RUN npm ci --verbose --ignore-scripts
RUN npm ci --legacy-peer-deps --ignore-scripts

CMD ["make", "lint"]
###############################################################################
Expand Down Expand Up @@ -122,7 +122,7 @@ COPY ./Makefile ${WORKDIR}/
COPY ./package.json ${WORKDIR}/package.json
COPY ./package-lock.json ${WORKDIR}/package-lock.json

RUN npm ci --verbose --omit=dev --omit=optional --ignore-scripts --no-cache \
RUN npm ci --legacy-peer-deps --omit=dev --omit=optional --ignore-scripts --no-cache \
&& ls -alh

USER node
Expand Down
2 changes: 1 addition & 1 deletion Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ dependencies:
@echo "################################################################################"
@echo "## Dependencies: ###############################################################"
@echo "################################################################################"
test -x ./node_modules || npm install --verbose
test -x ./node_modules || npm install --verbose --legacy-peer-deps
@echo "################################################################################"

lint/json:
Expand Down
4 changes: 4 additions & 0 deletions eslint.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,6 +63,10 @@ export default [
'no-restricted-syntax': 0,
'no-console': 'off',
'no-underscore-dangle': 0,
// Disable jest rules that require TypeScript type information
'jest/no-error-equal': 0,
'jest/no-unnecessary-assertion': 0,
'jest/valid-expect-with-promise': 0,

'no-plusplus': [
'error',
Expand Down
Loading