Merge pull request #998 from sir-gon/develop

Many fixes to upgrade Eslint from 9.x to 10.x

Author: sir-gon

.github/workflows/node.js.yml

@@ -16,7 +16,7 @@ jobs:
     strategy:
       matrix:
         os: ["ubuntu-24.04", "macos-14", "windows-2022"]
-        node-version: [18.x, 20.x, 22.x]
+        node-version: [22.x, 24.x, 26.x]
         # See supported Node.js release schedule
         # at https://nodejs.org/en/about/releases/
 

Makefile

@@ -95,7 +95,7 @@ coverage: test
 
 coverage/html: coverage
 	@if [ "$$(uname)" = "Darwin" ]; then \
-		open ./coverage/lcov-report/index.htmll; \
+		open ./coverage/lcov-report/index.html; \
 	elif [ "$$(uname | tr '[:upper:]' '[:lower:]')" = "mingw32" ] || [ "$$(uname | tr '[:upper:]' '[:lower:]')" = "mingw64" ] || [ "$$(uname | tr '[:upper:]' '[:lower:]')" = "cygwin" ]; then \
 		cmd /c start ./coverage/lcov-report/index.htmll; \
 	else \

eslint.config.mjs

@@ -1,112 +1,52 @@
-import { fixupConfigRules, fixupPluginRules } from '@eslint/compat';
-import typescriptEslint from '@typescript-eslint/eslint-plugin';
-import _import from 'eslint-plugin-import';
+import neostandard from 'neostandard';
+import tseslint from 'typescript-eslint';
 import jest from 'eslint-plugin-jest';
 import prettier from 'eslint-plugin-prettier';
-import tsParser from '@typescript-eslint/parser';
-import path from 'node:path';
-import { fileURLToPath } from 'node:url';
-import js from '@eslint/js';
-import { FlatCompat } from '@eslint/eslintrc';
+import prettierConfig from 'eslint-config-prettier';
 
-const __filename = fileURLToPath(import.meta.url);
-const __dirname = path.dirname(__filename);
-const compat = new FlatCompat({
-  baseDirectory: __dirname,
-  recommendedConfig: js.configs.recommended,
-  allConfig: js.configs.all
-});
-
-export default [
+export default tseslint.config(
+  ...neostandard({
+    ts: true,
+  }),
   {
-    ignores: ['**/coverage', '**/dist', '**/node_modules', '**/*.js']
+    ignores: ['**/coverage', '**/dist', '**/node_modules', 'eslint.config.mjs'],
   },
-  ...fixupConfigRules(
-    compat.extends(
-      'eslint:recommended',
-      'plugin:@typescript-eslint/eslint-recommended',
-      'plugin:@typescript-eslint/recommended',
-      'plugin:@typescript-eslint/recommended-type-checked',
-      'plugin:@typescript-eslint/stylistic-type-checked',
-      'airbnb-base',
-      'prettier',
-      'plugin:import/recommended',
-      'plugin:import/errors',
-      'plugin:import/warnings',
-      'plugin:jest/all'
-    )
-  ),
   {
-    plugins: {
-      '@typescript-eslint': fixupPluginRules(typescriptEslint),
-      import: fixupPluginRules(_import),
-      jest: fixupPluginRules(jest),
-      prettier
-    },
-
+    files: ['**/*.ts', '**/*.mts', '**/*.cts', '**/*.tsx'],
     languageOptions: {
-      parser: tsParser,
-      ecmaVersion: 5,
-      sourceType: 'script',
-
       parserOptions: {
-        project: true
-      }
-    },
-
-    settings: {
-      'import/parsers': {
-        '@typescript-eslint/parser': ['.ts', '.tsx']
+        project: true,
       },
-
-      'import/resolver': {
-        typescript: {
-          alwaysTryTypes: true,
-          project: '.'
-        }
-      }
     },
-
+    plugins: {
+      jest,
+      prettier,
+    },
     rules: {
+      ...jest.configs.all.rules,
+      ...prettierConfig.rules,
       'prettier/prettier': ['error'],
-
-      'import/extensions': [
-        'error',
-        'always',
-        {
-          pattern: {
-            ts: 'never'
-          }
-        }
-      ],
-
       'no-restricted-syntax': 0,
       'no-console': 'off',
       'no-underscore-dangle': 0,
-
       'no-plusplus': [
         'error',
         {
-          allowForLoopAfterthoughts: true
-        }
+          allowForLoopAfterthoughts: true,
+        },
       ],
-
       'no-shadow': 'off',
       '@typescript-eslint/no-shadow': 'error',
       'no-unused-vars': 'off',
-      '@typescript-eslint/no-unused-vars': 'error',
+      '@typescript-eslint/no-unused-vars': [
+        'error',
+        {
+          argsIgnorePattern: '^_',
+        },
+      ],
       'no-use-before-define': 'off',
-      '@typescript-eslint/no-use-before-define': 'error'
-    }
-  },
-  {
-    files: ['**/*.ts', '**/*.mts', '**/*.cts', '**/*.tsx'],
-
-    rules: {
-      '@typescript-eslint/explicit-function-return-type': 'error'
-    }
-  },
-  {
-    ignores: ["dist/*", "coverage/*", "node_modules/*", "eslint.config.mjs"]
+      '@typescript-eslint/no-use-before-define': 'error',
+      '@typescript-eslint/explicit-function-return-type': 'error',
+    },
   }
-];
+);