Eslint upgrade fixes

Author: Gonzalo Diaz

src/hackerrank/interview_preparation_kit/search/ctci_ice_cream_parlor.test.ts

@@ -7,7 +7,7 @@ import TEST_CASES_BORDER_CASES from './ctci_ice_cream_parlor.border_testcases.js
 
 describe('ctci_ice_cream_parlor', () => {
   it('whatFlavorsCompute test cases', () => {
-    expect.assertions(12);
+    expect.assertions(7);
 
     let totalTestsCount = 0;
 
@@ -20,7 +20,8 @@ describe('ctci_ice_cream_parlor', () => {
         );
 
         expect(answer).toStrictEqual(test.expected);
-        expect(whatFlavors(test.costs, test.money)).toBeUndefined();
+
+        whatFlavors(test.costs, test.money);
 
         totalTestsCount += 1;
       }
@@ -31,7 +32,7 @@ describe('ctci_ice_cream_parlor', () => {
   });
 
   it('whatFlavors border test cases', () => {
-    expect.assertions(4);
+    expect.assertions(3);
 
     let totalTestsCount = 0;
 
@@ -40,7 +41,8 @@ describe('ctci_ice_cream_parlor', () => {
         expect(whatFlavorsCompute(test.costs, test.money)).toStrictEqual(
           test.expected
         );
-        expect(whatFlavors(test.costs, test.money)).toBeUndefined();
+
+        whatFlavors(test.costs, test.money);
 
         totalTestsCount += 1;
       }
@@ -56,6 +58,6 @@ describe('ctci_ice_cream_parlor', () => {
     const cost: number[] = [];
     const money = 100;
 
-    expect(whatFlavors(cost, money)).toBeUndefined();
+    expect(() => whatFlavors(cost, money)).not.toThrow();
   });
 });

src/hackerrank/interview_preparation_kit/search/ctci_ice_cream_parlor_bruteforce.test.ts

@@ -10,7 +10,7 @@ import TEST_CASES_BORDER_CASES from './ctci_ice_cream_parlor.border_testcases.js
 
 describe('ctci_ice_cream_parlor_bruteforce', () => {
   it('whatFlavors test cases', () => {
-    expect.assertions(12);
+    expect.assertions(7);
 
     let totalTestsCount = 0;
 
@@ -23,7 +23,8 @@ describe('ctci_ice_cream_parlor_bruteforce', () => {
         );
 
         expect(answer).toStrictEqual(test.expected);
-        expect(whatFlavors(test.costs, test.money)).toBeUndefined();
+
+        whatFlavors(test.costs, test.money);
 
         totalTestsCount += 1;
       }
@@ -34,7 +35,7 @@ describe('ctci_ice_cream_parlor_bruteforce', () => {
   });
 
   it('whatFlavors border test cases', () => {
-    expect.assertions(4);
+    expect.assertions(3);
 
     let totalTestsCount = 0;
 
@@ -43,7 +44,8 @@ describe('ctci_ice_cream_parlor_bruteforce', () => {
         expect(
           whatFlavorsBruteforceCompute(test.costs, test.money)
         ).toStrictEqual(test.expected);
-        expect(whatFlavors(test.costs, test.money)).toBeUndefined();
+
+        whatFlavors(test.costs, test.money);
 
         totalTestsCount += 1;
       }
@@ -59,6 +61,6 @@ describe('ctci_ice_cream_parlor_bruteforce', () => {
     const cost: number[] = [];
     const money = 100;
 
-    expect(whatFlavors(cost, money)).toBeUndefined();
+    expect(() => whatFlavors(cost, money)).not.toThrow();
   });
 });

src/hackerrank/interview_preparation_kit/search/ctci_ice_cream_parlor_optimized.test.ts

@@ -10,7 +10,7 @@ import TEST_CASES_BORDER_CASES from './ctci_ice_cream_parlor.border_testcases.js
 
 describe('ctci_ice_cream_parlor_optimized', () => {
   it('whatFlavorsCompute test cases', () => {
-    expect.assertions(12);
+    expect.assertions(7);
 
     let totalTestsCount = 0;
 
@@ -23,7 +23,8 @@ describe('ctci_ice_cream_parlor_optimized', () => {
         );
 
         expect(answer).toStrictEqual(test.expected);
-        expect(whatFlavors(test.costs, test.money)).toBeUndefined();
+
+        whatFlavors(test.costs, test.money);
 
         totalTestsCount += 1;
       }
@@ -34,7 +35,7 @@ describe('ctci_ice_cream_parlor_optimized', () => {
   });
 
   it('whatFlavors border test cases', () => {
-    expect.assertions(4);
+    expect.assertions(3);
 
     let totalTestsCount = 0;
 
@@ -43,7 +44,8 @@ describe('ctci_ice_cream_parlor_optimized', () => {
         expect(whatFlavorsCompute(test.costs, test.money)).toStrictEqual(
           test.expected
         );
-        expect(whatFlavors(test.costs, test.money)).toBeUndefined();
+
+        whatFlavors(test.costs, test.money);
 
         totalTestsCount += 1;
       }
@@ -59,6 +61,6 @@ describe('ctci_ice_cream_parlor_optimized', () => {
     const cost: number[] = [];
     const money = 100;
 
-    expect(whatFlavors(cost, money)).toBeUndefined();
+    expect(() => whatFlavors(cost, money)).not.toThrow();
   });
 });

src/hackerrank/interview_preparation_kit/search/swap_nodes_algo.test.ts

@@ -1,34 +1,31 @@
 import { describe, expect, it } from '@jest/globals';
 
-import { Node } from '../../lib/Node';
 import { Tree, swapNodes, __INITIAL_LEVEL__ } from './swap_nodes_algo';
 import TEST_CASES from './swap_nodes_algo.testcases.json';
 
 describe('swap_nodes_algo', () => {
   it('test_buildTree_empty', () => {
-    expect.assertions(4);
+    expect.assertions(2);
 
     const input: number[][] = [];
     const tree: Tree = new Tree(input);
     const expected: number[] = [1];
 
     expect(tree.flatTree()).toStrictEqual(expected);
-    expect(tree.getRoot()).not.toBeNull();
-    expect(tree.getRoot()).toBeInstanceOf(Node);
+
     expect(tree.getRoot().data).toBe(__INITIAL_LEVEL__);
   });
 
   it('test_build_malformed_tree', () => {
-    expect.assertions(4);
+    expect.assertions(2);
 
     const input: number[][] = [[], []];
     const tree: Tree = new Tree(input);
     const tresult: number[] = tree.flatTree();
     const expected: number[] = [__INITIAL_LEVEL__];
 
     expect(tresult).toStrictEqual(expected);
-    expect(tree.getRoot()).not.toBeNull();
-    expect(tree.getRoot()).toBeInstanceOf(Node);
+
     expect(tree.getRoot().data).toBe(__INITIAL_LEVEL__);
   });
 

src/hackerrank/interview_preparation_kit/sort/ctci_bubble_sort.test.ts

@@ -5,14 +5,13 @@ import TEST_CASES from './ctci_bubble_sort.testcases.json';
 
 describe('countSwaps', () => {
   it('build tree and flattened tree test cases', () => {
-    expect.assertions(7);
+    expect.assertions(4);
 
     for (const test of TEST_CASES) {
       const sortable = new SortableGroup(test.input);
       const resultSort = sortable.bubble_sort().group;
-      const resultPrint = countSwaps(test.input);
+      countSwaps(test.input);
 
-      expect(resultPrint).toBeUndefined();
       expect(resultSort).toStrictEqual(test.sorted);
     }
 

src/hackerrank/interview_preparation_kit/sort/ctci_comparator_sorting.test.ts

@@ -24,7 +24,7 @@ describe('comparatorSorting', () => {
   });
 
   it('test_comparator_sorting', () => {
-    expect.assertions(9);
+    expect.assertions(5);
 
     for (const test of TEST_CASES) {
       const players: SortablePlayer[] = [];
@@ -34,7 +34,8 @@ describe('comparatorSorting', () => {
       }
 
       expect(comparatorSorting(players)).toStrictEqual(test.sorted);
-      expect(comparatorSortingPrint(players)).toBeUndefined();
+
+      comparatorSortingPrint(players);
     }
 
     expect(TEST_CASES).toHaveLength(4);

src/logger.ts

@@ -1,4 +1,3 @@
-/* eslint-disable jest/require-hook */
 /* istanbul ignore file */
 
 import pino from 'pino';