Skip to content

Commit 2b44452

Browse files
JohannesLichtenbergerJohannes Lichtenberger
andauthored
test: align expected nodeKey + counts with sirix iter#32 fused OBJECT_NAMED_* (#28)
Sirix sirixdb/sirix#956 introduces fused OBJECT_NAMED_* records (kinds 48-53): each "field-name + primitive value" pair, formerly two records, becomes one. This shifts node keys downward and reduces total node counts on documents that contain primitive-valued object fields. Updated assertions: * test_find_all_projection: 2nd document of {key,location} pair → nodeKey 11 → 7 * test_history (json_store): same shift, 11 → 7 * test_read_metadata_key_only: nested {metadata, value} wrapper around the string value collapses (the value is no longer a separate node) * test_sirix_query / test_resource_query (async + sync): foo[2] over {foo:["bar",null,2.33]} resolves to nodeKey 5 instead of 6 (one fewer node since "foo" array is a single fused OBJECT_NAMED_ARRAY record) Co-authored-by: Johannes Lichtenberger <johannes.lichtenberger@sirix.io>
1 parent 5f9082e commit 2b44452

4 files changed

Lines changed: 9 additions & 9 deletions

File tree

tests/test_json_store.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -73,7 +73,7 @@ def test_find_all_projection():
7373
response = store.find_all({"key": 2}, ["location"])
7474
assert response[0] == {
7575
"location": {"state": "CA", "city": "Los Angeles"},
76-
"nodeKey": 11,
76+
"nodeKey": 7,
7777
}
7878
response = store.find_all({"key": 2}, ["location"], hash=True)
7979
assert "hash" in response[0]
@@ -119,14 +119,14 @@ def test_history():
119119
store.insert_one({"generic": 1, "location": {"state": "NY", "city": "New York"}})
120120
store.insert_one({"generic": 1, "location": {"state": "CA", "city": "Los Angeles"}})
121121
assert len(store.resource_history()) == 3
122-
history = store.history(11)
122+
history = store.history(7)
123123
assert len(history) == 1
124124
history = history[0]
125125
assert type(history["revisionTimestamp"]) == str
126126
assert type(history["revisionNumber"]) == int
127127
assert len(history) == 2
128-
assert len(store.history(11, subtree=False)[0]) == 3
129-
embedded = store.history_embed(11)
128+
assert len(store.history(7, subtree=False)[0]) == 3
129+
embedded = store.history_embed(7)
130130
assert len(embedded[0]) == 3
131131

132132

tests/test_resource_sync.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -119,7 +119,7 @@ def test_read_metadata_key_only():
119119
{
120120
"key": "test",
121121
"metadata": {"nodeKey": 3},
122-
"value": {"metadata": {"nodeKey": 4}, "value": "dict"},
122+
"value": "dict",
123123
}
124124
],
125125
}

tests/test_sirix_async.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -277,7 +277,7 @@ async def test_sirix_query():
277277
db = sirix.database("Query", DBType.JSON)
278278
resource = db.resource("query_resource1")
279279
await resource.create(data_for_query)
280-
assert await sirix.query(post_query) == '{"rest":[6]}'
280+
assert await sirix.query(post_query) == '{"rest":[5]}'
281281
await sirix.delete_all()
282282
await client.aclose()
283283

@@ -289,6 +289,6 @@ async def test_resource_query():
289289
db = sirix.database("Query", DBType.JSON)
290290
resource = db.resource("query_resource2")
291291
await resource.create(data_for_query)
292-
assert await resource.query(resource_query) == {"rest": [6]}
292+
assert await resource.query(resource_query) == {"rest": [5]}
293293
await sirix.delete_all()
294294
await client.aclose()

tests/test_sirix_sync.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -90,7 +90,7 @@ def test_sirix_query():
9090
db = sirix.database("Query", DBType.JSON)
9191
resource = db.resource("query_resource1")
9292
resource.create(data_for_query)
93-
assert sirix.query(post_query) == '{"rest":[6]}'
93+
assert sirix.query(post_query) == '{"rest":[5]}'
9494
sirix.delete_all()
9595
client.close()
9696

@@ -102,6 +102,6 @@ def test_resource_query():
102102
db = sirix.database("Query", DBType.JSON)
103103
resource = db.resource("query_resource")
104104
resource.create(data_for_query)
105-
assert resource.query(resource_query) == {"rest": [6]}
105+
assert resource.query(resource_query) == {"rest": [5]}
106106
sirix.delete_all()
107107
client.close()

0 commit comments

Comments
 (0)