Commit 4fefc51
fix: silence stderr on best-effort package-manager probes (#491)
When bun is on PATH but its global directory was never initialized
(no `bun add -g` ever run), launching the config TUI prints
`error: No package.json was found for directory "~/.bun/install/global"`
into the terminal. The TUI probes `bun pm bin -g` (and `where`/`which`,
`npm prefix -g`, `npm root -g`) via execFileSync without an stdio
option, so the child's stderr is inherited by the parent terminal even
though the thrown error itself is caught and treated as "not found".
Add stdio: ['ignore', 'pipe', 'ignore'] to these best-effort probes
(stdout stays piped for the return value), matching the pattern already
used elsewhere in the codebase. Adds regression tests asserting every
probe call suppresses stderr and that a throwing bun probe degrades
gracefully.
Co-authored-by: Claude Fable 5 <noreply@anthropic.com>1 parent 44f49d3 commit 4fefc51
3 files changed
Lines changed: 37 additions & 3 deletions
File tree
- src/utils
- __tests__
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
71 | 71 | | |
72 | 72 | | |
73 | 73 | | |
| 74 | + | |
| 75 | + | |
| 76 | + | |
| 77 | + | |
| 78 | + | |
| 79 | + | |
| 80 | + | |
| 81 | + | |
| 82 | + | |
| 83 | + | |
| 84 | + | |
| 85 | + | |
| 86 | + | |
| 87 | + | |
| 88 | + | |
| 89 | + | |
| 90 | + | |
| 91 | + | |
| 92 | + | |
| 93 | + | |
| 94 | + | |
| 95 | + | |
| 96 | + | |
| 97 | + | |
| 98 | + | |
| 99 | + | |
74 | 100 | | |
75 | 101 | | |
76 | 102 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
55 | 55 | | |
56 | 56 | | |
57 | 57 | | |
58 | | - | |
| 58 | + | |
| 59 | + | |
59 | 60 | | |
60 | 61 | | |
61 | 62 | | |
62 | 63 | | |
63 | | - | |
| 64 | + | |
| 65 | + | |
64 | 66 | | |
65 | 67 | | |
66 | 68 | | |
| |||
76 | 78 | | |
77 | 79 | | |
78 | 80 | | |
| 81 | + | |
79 | 82 | | |
80 | 83 | | |
81 | 84 | | |
| |||
93 | 96 | | |
94 | 97 | | |
95 | 98 | | |
| 99 | + | |
| 100 | + | |
| 101 | + | |
96 | 102 | | |
97 | 103 | | |
98 | 104 | | |
99 | | - | |
| 105 | + | |
| 106 | + | |
100 | 107 | | |
101 | 108 | | |
102 | 109 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
183 | 183 | | |
184 | 184 | | |
185 | 185 | | |
| 186 | + | |
186 | 187 | | |
187 | 188 | | |
188 | 189 | | |
| |||
0 commit comments