Revert TEXTAREA into its own test, keep PRE/LISTING data provider

claude · claude · commit 78db4934c0bb · 2026-02-05T22:15:23.000Z
TEXTAREA is a raw text element with different navigation semantics and should remain a separate test. Only PRE and LISTING share the same test structure. https://claude.ai/code/session_019ux8qzita5FCCk6v6A9cui
diff --git a/tests/phpunit/tests/html-api/wpHtmlTagProcessorModifiableText.php b/tests/phpunit/tests/html-api/wpHtmlTagProcessorModifiableText.php
@@ -638,35 +638,47 @@ public function test_json_auto_escaping() {
 	}
 
 	/**
-	 * TEXTAREA, PRE, and LISTING elements ignore the first newline in their content.
+	 * TEXTAREA elements ignore the first newline in their content.
+	 * Setting the modifiable text with a leading newline should ensure that the leading newline
+	 * is present in the resulting TEXTAREA.
+	 *
+	 * @ticket 64607
+	 */
+	public function test_modifiable_text_special_textarea() {
+		$processor = new WP_HTML_Tag_Processor( '<textarea></textarea>' );
+		$processor->next_token();
+		$processor->set_modifiable_text( "\nAFTER NEWLINE" );
+		$this->assertSame(
+			"\nAFTER NEWLINE",
+			$processor->get_modifiable_text(),
+			'Should have preserved the leading newline in the TEXTAREA content.'
+		);
+	}
+
+	/**
+	 * PRE and LISTING elements ignore the first newline in their content.
 	 * Setting the modifiable text with a leading newline should ensure that the leading newline
 	 * is present in the resulting element.
 	 *
 	 * @ticket 64607
 	 *
-	 * @dataProvider data_modifiable_text_special_leading_newline_elements
+	 * @dataProvider data_modifiable_text_special_pre_tags
 	 *
-	 * @param string $html             HTML containing the element to test.
-	 * @param int    $advance_n_tokens Count of times to run `next_token()` before reaching target node.
-	 * @param string $expected_html    Expected HTML output after setting modifiable text.
+	 * @param string $tag_name The tag name to test (e.g. 'pre', 'listing').
 	 */
-	public function test_modifiable_text_special_leading_newline_elements( string $html, int $advance_n_tokens, string $expected_html ) {
+	public function test_modifiable_text_special_pre_tags( string $tag_name ) {
 		$set_text  = "\nAFTER NEWLINE";
-		$processor = new WP_HTML_Tag_Processor( $html );
-		while ( --$advance_n_tokens >= 0 ) {
-			$processor->next_token();
-		}
+		$processor = new WP_HTML_Tag_Processor( "<{$tag_name}>REPLACEME<!--x--></{$tag_name}>" );
+		$processor->next_tag();
+		$processor->next_token();
+		$this->assertSame( '#text', $processor->get_token_type() );
 		$processor->set_modifiable_text( $set_text );
-		$this->assertSame(
-			$set_text,
-			$processor->get_modifiable_text(),
-			'Should have preserved the leading newline.'
-		);
+		$this->assertSame( $set_text, $processor->get_modifiable_text() );
 		$this->assertEqualHTML(
-			$expected_html,
+			"<{$tag_name}>\n{$set_text}<!--x--></{$tag_name}>",
 			$processor->get_updated_html(),
 			'<body>',
-			'Should have preserved the leading newline in the element content.'
+			"Should have preserved the leading newline in the {$tag_name} content."
 		);
 	}
 
@@ -675,13 +687,10 @@ public function test_modifiable_text_special_leading_newline_elements( string $h
 	 *
 	 * @return array[]
 	 */
-	public static function data_modifiable_text_special_leading_newline_elements() {
-		$set_text = "\nAFTER NEWLINE";
-
+	public static function data_modifiable_text_special_pre_tags() {
 		return array(
-			'TEXTAREA' => array( '<textarea></textarea>', 1, "<textarea>\n{$set_text}</textarea>" ),
-			'PRE'      => array( '<pre>REPLACEME<!--x--></pre>', 2, "<pre>\n{$set_text}<!--x--></pre>" ),
-			'LISTING'  => array( '<listing>REPLACEME<!--x--></listing>', 2, "<listing>\n{$set_text}<!--x--></listing>" ),
+			'PRE'     => array( 'pre' ),
+			'LISTING' => array( 'listing' ),
 		);
 	}
 }
