Plugins: Hide the search form on the Favorites tab.

The plugin search form does not apply to the Favorites tab, which instead expects a WordPress.org username to look up a user's favorited plugins. Rendering the term-based search form there was misleading. Update `WP_Plugin_Install_List_Table::views()` to read the global `$tab` and skip `install_search_form()` when the favorites tab is active, while leaving the form in place on the Featured, Popular, and Recommended tabs.

Developed in WordPress#11457.

Props manishxdp, bor0, westonruter, shailu25, sabbir1991.
Fixes #65026.


git-svn-id: https://develop.svn.wordpress.org/trunk@62448 602fd350-edb4-49c9-b593-d223f7449a82

Author: westonruter

src/wp-admin/includes/class-wp-plugin-install-list-table.php

@@ -331,8 +331,12 @@ protected function get_views() {
 
 	/**
 	 * Overrides parent views so we can use the filter bar display.
+	 *
+	 * @global string $tab The current tab.
 	 */
 	public function views() {
+		global $tab;
+
 		$views = $this->get_views();
 
 		/** This filter is documented in wp-admin/includes/class-wp-list-table.php */
@@ -358,7 +362,11 @@ public function views() {
 		?>
 	</ul>
 
-		<?php install_search_form(); ?>
+		<?php
+		if ( 'favorites' !== $tab ) {
+			install_search_form();
+		}
+		?>
 </div>
 		<?php
 	}