Closed
Conversation
dmsnell
reviewed
Jan 21, 2026
| 'abc', | ||
| ), | ||
| ); | ||
| $expected = parse_blocks( $html )[0]; |
Collaborator
There was a problem hiding this comment.
I expected to use expected as expected but then expected was reassigned :)
Owner
Author
There was a problem hiding this comment.
Yes, this was quick and dirty debugging. Keeping you on your toes 😉
(Originally I wanted a static view of what was expected, but it was more comfortable to assert "produce the same result as parse_blocks()").
dmsnell
added a commit
to dmsnell/wordpress-develop
that referenced
this pull request
Jan 21, 2026
Initially ported from sirreal#20 Co-authored-by: Jon Surrell <jonsurrell@git.wordpress.org>
dmsnell
added a commit
to dmsnell/wordpress-develop
that referenced
this pull request
Jan 21, 2026
Trac ticket: Core-64537 Initially ported from sirreal#20 Developed in: WordPress#10769 Discussed in: https://core.trac.wordpress.org/ticket/64537#ticket Follow-up to [[60939]](https://core.trac.wordpress.org/changeset/60939). Props jonsurrell, dmsnell. Fixes Core-64537 Co-authored-by: Jon Surrell <jonsurrell@git.wordpress.org> Github-PR: 10769 Github-PR-URL: WordPress#10769 Trac-Ticket: 64537 Trac-Ticket-URL: https://core.trac.wordpress.org/ticket/64537 Branch-Name: blocks/add-block-processor-tests
dmsnell
added a commit
to dmsnell/wordpress-develop
that referenced
this pull request
Jan 21, 2026
Trac ticket: Core-64537 Initially ported from sirreal#20 Developed in: WordPress#10769 Discussed in: https://core.trac.wordpress.org/ticket/64537#ticket Follow-up to [[60939]](https://core.trac.wordpress.org/changeset/60939). Props jonsurrell, dmsnell. Fixes Core-64537 Co-authored-by: Jon Surrell <jonsurrell@git.wordpress.org> Github-PR: 10769 Github-PR-URL: WordPress#10769 Trac-Ticket: 64537 Trac-Ticket-URL: https://core.trac.wordpress.org/ticket/64537 Branch-Name: blocks/add-block-processor-tests
dmsnell
added a commit
to dmsnell/wordpress-develop
that referenced
this pull request
Jan 21, 2026
Trac ticket: Core-64537 Initially ported from sirreal#20 Developed in: WordPress#10769 Discussed in: https://core.trac.wordpress.org/ticket/64537#ticket Follow-up to [[60939]](https://core.trac.wordpress.org/changeset/60939). Props jonsurrell, dmsnell. Fixes Core-64537 Co-authored-by: Jon Surrell <jonsurrell@git.wordpress.org> Github-PR: 10769 Github-PR-URL: WordPress#10769 Trac-Ticket: 64537 Trac-Ticket-URL: https://core.trac.wordpress.org/ticket/64537 Branch-Name: blocks/add-block-processor-tests
dmsnell
added a commit
to dmsnell/wordpress-develop
that referenced
this pull request
Jan 21, 2026
Trac ticket: Core-64537 Initially ported from sirreal#20 Developed in: WordPress#10769 Discussed in: https://core.trac.wordpress.org/ticket/64537#ticket Follow-up to [[60939]](https://core.trac.wordpress.org/changeset/60939). Props jonsurrell, dmsnell. Fixes Core-64537 Co-authored-by: Jon Surrell <jonsurrell@git.wordpress.org> Github-PR: 10769 Github-PR-URL: WordPress#10769 Trac-Ticket: 64537 Trac-Ticket-URL: https://core.trac.wordpress.org/ticket/64537 Branch-Name: blocks/add-block-processor-tests
dmsnell
added a commit
to dmsnell/wordpress-develop
that referenced
this pull request
Jan 21, 2026
Trac ticket: Core-64537 Initially ported from sirreal#20 Developed in: WordPress#10769 Discussed in: https://core.trac.wordpress.org/ticket/64537#ticket Follow-up to [[60939]](https://core.trac.wordpress.org/changeset/60939). Props jonsurrell, dmsnell. Fixes Core-64537 Co-authored-by: Jon Surrell <jonsurrell@git.wordpress.org> Github-PR: 10769 Github-PR-URL: WordPress#10769 Trac-Ticket: 64537 Trac-Ticket-URL: https://core.trac.wordpress.org/ticket/64537 Branch-Name: blocks/add-block-processor-tests
dmsnell
added a commit
to dmsnell/wordpress-develop
that referenced
this pull request
Jan 21, 2026
Trac ticket: Core-64537 Initially ported from sirreal#20 Developed in: WordPress#10769 Discussed in: https://core.trac.wordpress.org/ticket/64537#ticket Follow-up to [[60939]](https://core.trac.wordpress.org/changeset/60939). Props dmsnell, jonsurrell, jorbin. Fixes Core-64537 Co-Authored-By: Jon Surrell <jonsurrell@git.wordpress.org> Co-Authored-By: Aaron Jorbin <jorbin@git.wordpres.org> Github-PR: 10769 Github-PR-URL: WordPress#10769 Trac-Ticket: 64537 Trac-Ticket-URL: https://core.trac.wordpress.org/ticket/64537 Branch-Name: blocks/add-block-processor-tests
dmsnell
added a commit
to dmsnell/wordpress-develop
that referenced
this pull request
Jan 21, 2026
Trac ticket: Core-64537 Initially ported from sirreal#20 Developed in: WordPress#10769 Discussed in: https://core.trac.wordpress.org/ticket/64537#ticket Follow-up to [[60939]](https://core.trac.wordpress.org/changeset/60939). Props dmsnell, jonsurrell, jorbin. Fixes Core-64537 Co-Authored-By: Jon Surrell <jonsurrell@git.wordpress.org> Co-Authored-By: Aaron Jorbin <jorbin@git.wordpres.org> Github-PR: 10769 Github-PR-URL: WordPress#10769 Trac-Ticket: 64537 Trac-Ticket-URL: https://core.trac.wordpress.org/ticket/64537 Branch-Name: blocks/add-block-processor-tests
dmsnell
added a commit
to dmsnell/wordpress-develop
that referenced
this pull request
Jan 21, 2026
Trac ticket: Core-64537 Initially ported from sirreal#20 Developed in: WordPress#10769 Discussed in: https://core.trac.wordpress.org/ticket/64537#ticket Follow-up to [[60939]](https://core.trac.wordpress.org/changeset/60939). Props dmsnell, jonsurrell, jorbin. Fixes Core-64537 Co-Authored-By: Jon Surrell <jonsurrell@git.wordpress.org> Co-Authored-By: Aaron Jorbin <jorbin@git.wordpres.org> Github-PR: 10769 Github-PR-URL: WordPress#10769 Trac-Ticket: 64537 Trac-Ticket-URL: https://core.trac.wordpress.org/ticket/64537 Branch-Name: blocks/add-block-processor-tests
dmsnell
added a commit
to dmsnell/wordpress-develop
that referenced
this pull request
Jan 21, 2026
WordPress#10769) Trac ticket: Core-64537 Initially ported from sirreal#20 The behavior of WP_Block_Processor::extract_full_block_and_advance() should produce an identical output to what parse_blocks() would return on the same substring of input. Unfortunately, when HTML spans followed inner blocks, they were being omitted in the output parse tree. This was due to an omission in the original code which would look for those blocks before advancing again after calling `extract_full_block_and_advance()` recursively. This patch adds the missing check and resolves the discrepancy. Developed in: WordPress#10769 Discussed in: https://core.trac.wordpress.org/ticket/64537#ticket Follow-up to [[60939]](https://core.trac.wordpress.org/changeset/60939). Props dmsnell, jonsurrell, jorbin. Fixes Core-64537 Co-Authored-By: Jon Surrell <jonsurrell@git.wordpress.org> Co-Authored-By: Aaron Jorbin <jorbin@git.wordpress.org> Github-PR: 10769 Github-PR-URL: WordPress#10769 Trac-Ticket: 64537 Trac-Ticket-URL: https://core.trac.wordpress.org/ticket/64537 Branch-Name: blocks/add-block-processor-tests
Collaborator
|
full test suite in WordPress#10769 |
Collaborator
|
Unless I have misread the tests or neglected something, this should be resolved as of the merge of WordPress@d3068ae |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Noodling…