HTML API: Limit leading newline serialization to HTML elements#45
Open
sirreal wants to merge 1 commit into
Open
HTML API: Limit leading newline serialization to HTML elements#45sirreal wants to merge 1 commit into
sirreal wants to merge 1 commit into
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Owner
Author
Code reviewNo issues found. Checked for bugs and CLAUDE.md compliance. 🤖 Generated with Claude Code |
sirreal
added a commit
that referenced
this pull request
Jun 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
textarea,pre, andlistingto tokens in the HTML namespace.textareaelements, HTML integration-pointtextareabehavior, andpre/listingforeign-content exit behavior.Root Cause
WP_HTML_Processor::serialize_token()applied the HTMLtextarea/pre/listingleading-LF restoration rule by tag name alone. Foreign SVG and MathML elements with local nametextareado not have that parser-stripped leading newline, so normalization inserted an extra LF and was not idempotent.Verification
WP_TESTS_SKIP_INSTALL=1 ./vendor/bin/phpunit --group html-api,html-api-html5lib-tests./vendor/bin/phpcs src/wp-includes/html-api/class-wp-html-processor.php tests/phpunit/tests/html-api/wpHtmlProcessor-serialize.phpReview Notes
Three contrarian subagent review passes were run for the test, implementation, and final formatted diff. The requested
codex-review-loopskill was invoked after commit, butcodex reviewcould not complete: the sandboxed run failed and the required unsandboxed retry was rejected by policy because it may transmit repository diff data externally.