i18n: complete Korean (ko) translation#997
Open
moduvoice wants to merge 1 commit into
Open
Conversation
- Add missing src/i18n/locales/ko/tasks.json (94 keys), translated from en/tasks.json, and register it in src/i18n/config.js (ko was the only locale in config.js not importing/loading a tasks namespace bundle). - Add !src/i18n/locales/ko/tasks.json to .gitignore's task-file negation list — the blanket "tasks.json" ignore rule had no exception for ko, so the new file would otherwise be silently untracked. - Backfill settings.json (63 missing keys: voiceSettings, notifications.desktop, mainTabs.voice/browser, tabs.skills, mcpServers.managed, agents.account.opencode, and several pluginSettings entries), and remove one stray key (pluginSettings.buildYourOwn) that no longer exists in en. - Backfill smaller gaps found while auditing all locale files: chat.json (17 keys: voice.*, input.queue.*, opencode provider), codeEditor.json (5 keys: markdown preview/edit, filePreview.*), sidebar.json (11 keys: search.* and tooltips.clearSearch). All 7 ko/*.json files now have exact key parity with their en counterparts. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (7)
📝 WalkthroughWalkthroughThe Korean locale now includes task translations and expanded strings for chat, voice, search, code editing, settings, notifications, MCP servers, agents, and starter plugins. ChangesKorean i18n updates
Possibly related PRs
Suggested reviewers: Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
This completes the existing partial Korean (
ko) translation — Korean support was alreadypresent in this project but several files were missing keys, and one file (
tasks.json)was never loading at all due to a build-config bug — to help Korean-speaking users use this
open-source project more comfortably in their own language.
한국 사람들의 오픈소스 이용에 도움이 되게 하기 위해서 한글화 작업을 완료하였습니다.
Changes
src/i18n/locales/ko/tasks.json(94 keys, full parity withen/tasks.json)src/i18n/locales/ko/settings.json(+92 lines),chat.json(+27 lines,including
voice.*andinput.queue.*),codeEditor.json(+9 lines, including markdownpreview/edit strings), and
sidebar.json(+13 lines, includingsearch.*).gitignore: add!src/i18n/locales/ko/tasks.jsonexception. The file blanket-ignorestasks.jsonand then re-allows it per locale (en,fr,ja,ru,de,tr,it);kowas missing from that allowlist, so
ko/tasks.jsoncould never be committed even if it existed.src/i18n/config.js: register thekoTasksimport and add it to thekoresource bundle,following the exact same pattern already used for
ja/ru/de/tr/it/zh-TW.ko/tasks.jsonwas never imported before, so it would have silently never loaded even with the
.gitignorefixalone.
Testing
ko/*.jsonfiles (auth,chat,common,codeEditor,settings,sidebar,tasks) now have exact key parity with theirencounterparts (0 missing / 0 extra), checkedprogrammatically by flattening and diffing key sets.
ko/tasks.jsondid not exist onupstream/mainand was never imported insrc/i18n/config.jsprior to this change.npm run build— completes successfully (exit 0).npx eslint src/i18n/config.js— 0 errors (2 pre-existingimport-x/orderwarnings unrelatedto this change, present identically on
main).Summary by CodeRabbit