Skip to content

Commit 3923315

Browse files
committed
fixed empty message issue and changed the field names to http monitor specific names
1 parent 313ae99 commit 3923315

2 files changed

Lines changed: 15 additions & 10 deletions

File tree

src/main/java/org/graylog2/plugin/httpmonitor/HttpMonitorInputMetaData.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@ public URI getURL() {
3434

3535
@Override
3636
public Version getVersion() {
37-
return new Version(1, 0, 1);
37+
return new Version(1, 0, 2);
3838
}
3939

4040
@Override

src/main/java/org/graylog2/plugin/httpmonitor/HttpMonitorTransport.java

Lines changed: 14 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -170,23 +170,28 @@ public void run() {
170170
long time;
171171
Map<String, Object> eventdata = Maps.newHashMap();
172172
eventdata.put("version", "1.1");
173-
eventdata.put("_url", config.getUrl());
173+
eventdata.put("_http.monitor.url", config.getUrl());
174174
eventdata.put("_label", config.getLabel());
175175
try {
176176
Response response = requestBuilder.execute().get();
177177
long endTime = System.currentTimeMillis();
178178
time = endTime - startTime;
179179
eventdata.put("host", response.getUri().getHost());
180-
eventdata.put("_status", response.getStatusCode());
181-
eventdata.put("_statusLine", response.getStatusText());
180+
eventdata.put("_http.monitor.status", response.getStatusCode());
181+
eventdata.put("_http.monitor.statusLine", response.getStatusText());
182182
String responseBodyStr = new String(response.getResponseBodyAsBytes());
183-
eventdata.put("_size", responseBodyStr.length());
183+
eventdata.put("_http.monitor.responseSize", responseBodyStr.length());
184184
if (config.isLogResponseBody()) {
185185
eventdata.put("full_message", responseBodyStr);
186186
}
187187
String shortMessage = responseBodyStr.length() > 50 ? responseBodyStr.substring(0, 50) :
188188
responseBodyStr;
189+
if (shortMessage.isEmpty()) {
190+
shortMessage = "no_response";
191+
}
189192
eventdata.put("short_message", shortMessage);
193+
194+
190195
if (config.getResponseHeadersToRecord() != null) {
191196
for (String header : config.getResponseHeadersToRecord()) {
192197
eventdata.put("_" + header, response.getHeader(header));
@@ -195,24 +200,24 @@ public void run() {
195200
} catch (ExecutionException e) {
196201
eventdata.put("host", new URL(config.getUrl()).getHost());
197202
eventdata.put("short_message", "Request failed :" + e.getMessage());
198-
eventdata.put("_size", 0);
203+
eventdata.put("_http.monitor.responseSize", 0);
199204
long endTime = System.currentTimeMillis();
200205
time = endTime - startTime;
201206
//In case of connection timeout we get an execution exception with root cause as timeoutexception
202207
if (e.getCause() instanceof TimeoutException) {
203208
LOGGER.debug("Timeout while executing request for URL " + config.getUrl(), e);
204-
eventdata.put("_status", 998);
209+
eventdata.put("_http.monitor.status", 998);
205210
} else if (e.getCause() instanceof ConnectException) {
206211
//In case of connect exception we get an execution exception with root cause as connectexception
207212
LOGGER.debug("Exception while executing request for URL " + config.getUrl(), e);
208-
eventdata.put("_status", 999);
213+
eventdata.put("_http.monitor.status", 999);
209214
} else {
210215
//Any other exception..
211216
LOGGER.debug("Exception while executing request for URL " + config.getUrl(), e);
212-
eventdata.put("_status", 997);
217+
eventdata.put("_http.monitor.status", 997);
213218
}
214219
}
215-
eventdata.put("_responseTime", time);
220+
eventdata.put("_http.monitor.responseTime", time);
216221

217222
//publish to graylog server
218223
ByteArrayOutputStream byteStream = new ByteArrayOutputStream();

0 commit comments

Comments
 (0)