Commit c651ade
docs: minor script and documentation improvements from security review
Address four low-priority improvements identified during security review:
1. Add chmod reminder to hook-development SKILL.md - users copying example
scripts encounter permission errors; added note to make scripts executable
2. Parameterize plugin name in read-settings-hook.sh - replaced hardcoded
"my-plugin" with ${PLUGIN_NAME:-my-plugin} pattern to teach portable hooks
3. Add timeout to jq validation in test-hook.sh - maintains defensive
consistency with other timeout patterns in the script
4. Document race condition behavior in parse-frontmatter.sh - clarifies that
settings files are assumed stable (changes require Claude Code restart)
Fixes #163
🤖 Generated with [Claude Code](https://claude.com/claude-code)
Co-Authored-By: Claude <noreply@anthropic.com>1 parent ecfecb6 commit c651ade
4 files changed
Lines changed: 13 additions & 5 deletions
File tree
- plugins/plugin-dev/skills
- hook-development
- scripts
- plugin-settings
- examples
- scripts
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
689 | 689 | | |
690 | 690 | | |
691 | 691 | | |
| 692 | + | |
| 693 | + | |
692 | 694 | | |
693 | 695 | | |
694 | 696 | | |
| |||
Lines changed: 2 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
169 | 169 | | |
170 | 170 | | |
171 | 171 | | |
172 | | - | |
173 | | - | |
| 172 | + | |
| 173 | + | |
174 | 174 | | |
175 | 175 | | |
176 | 176 | | |
| |||
Lines changed: 5 additions & 3 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
2 | | - | |
| 2 | + | |
3 | 3 | | |
4 | 4 | | |
5 | 5 | | |
6 | 6 | | |
7 | | - | |
8 | | - | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
9 | 11 | | |
10 | 12 | | |
11 | 13 | | |
| |||
Lines changed: 4 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
2 | 2 | | |
3 | 3 | | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
4 | 8 | | |
5 | 9 | | |
6 | 10 | | |
| |||
0 commit comments