Skip to content

Commit e0284bb

Browse files
sjnimsclaude
andcommitted
feat(mcp-integration): address PR review suggestions
- Add installation hints for missing dependencies (curl, jq, gh) - Clarify transport flag as reserved for future registry API support - Update discovery.md to use --limit (long form) for consistency 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
1 parent 45c9ef2 commit e0284bb

2 files changed

Lines changed: 13 additions & 4 deletions

File tree

plugins/plugin-dev/skills/mcp-integration/references/discovery.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -272,7 +272,7 @@ Use the discovery script for automated server search with popularity ranking:
272272
./scripts/search-mcp-servers.sh database postgres
273273

274274
# Limit results and get JSON output
275-
./scripts/search-mcp-servers.sh -n 5 --format json filesystem
275+
./scripts/search-mcp-servers.sh --limit 5 --format json filesystem
276276

277277
# Simple output for scripting (stars|name|url)
278278
./scripts/search-mcp-servers.sh --format simple github

plugins/plugin-dev/skills/mcp-integration/scripts/search-mcp-servers.sh

Lines changed: 12 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -87,6 +87,14 @@ check_dependencies() {
8787
echo -e "${RED}❌ Missing required dependencies:${RESET}" >&2
8888
for dep in "${missing[@]}"; do
8989
echo " - $dep" >&2
90+
case "$dep" in
91+
"curl")
92+
echo " Install: brew install curl OR apt-get install curl" >&2 ;;
93+
"jq")
94+
echo " Install: brew install jq OR apt-get install jq" >&2 ;;
95+
"gh (GitHub CLI)")
96+
echo " Install: https://cli.github.com/" >&2 ;;
97+
esac
9098
done
9199
exit 1
92100
fi
@@ -342,11 +350,12 @@ main() {
342350
done < <(echo "$servers" | jq -c '.[]')
343351

344352
# Filter by transport if specified
353+
# NOTE: Transport filtering is reserved for future use. The MCP Registry API
354+
# does not currently include transport type in server metadata. When this data
355+
# becomes available, client-side filtering will be implemented here.
345356
if [ -n "$transport" ]; then
346-
# Note: Transport info may not be in registry response
347-
# This is a placeholder for when that data becomes available
348357
if [ "$format" = "table" ]; then
349-
echo -e "${YELLOW}Note: Transport filtering may not match all servers (data not always available)${RESET}"
358+
echo -e "${YELLOW}Note: Transport filtering not yet available (registry doesn't provide transport data)${RESET}"
350359
fi
351360
fi
352361

0 commit comments

Comments
 (0)