Skip to content

Commit e7a8045

Browse files
sjnimsclaude
andcommitted
fix: address PR review feedback
- Fix YAML indentation in github-actions.md nested example - Correct Bash permission pattern from git:* to git * (space, not colon) - Add explanation for why .local.md is lowest priority in memory hierarchy - Deduplicate agent hook type content with cross-reference Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
1 parent eb8494b commit e7a8045

3 files changed

Lines changed: 12 additions & 34 deletions

File tree

plugins/plugin-dev/skills/plugin-settings/references/memory-rules-system.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,8 @@ Memory files are loaded in priority order (highest first):
2222

2323
Higher-priority instructions take precedence when there are conflicts.
2424

25+
**Why local is lowest priority:** Unlike typical configuration systems where ".local" means "override", Claude Code's `.local.md` files are for personal, project-specific notes and preferences that shouldn't override team standards. The hierarchy ensures organizational policy (managed) > team standards (project) > personal preferences (user/local).
26+
2527
### Import Syntax
2628

2729
CLAUDE.md files can import other files:

plugins/plugin-dev/skills/plugin-structure/references/advanced-topics.md

Lines changed: 2 additions & 26 deletions
Original file line numberDiff line numberDiff line change
@@ -113,33 +113,9 @@ If your plugin's MCP server exposes resources, document the available resource U
113113

114114
The `agent` hook type (covered briefly in the hook-development SKILL.md) spawns a full subagent for complex verification workflows.
115115

116-
### Configuration
116+
For comprehensive coverage including configuration, behavior, supported events, when to use agent hooks, and detailed examples, see the hook-development skill's `references/advanced.md` file.
117117

118-
```json
119-
{
120-
"type": "agent",
121-
"prompt": "Verify all code changes have tests and pass linting",
122-
"timeout": 120
123-
}
124-
```
125-
126-
### Behavior
127-
128-
- Spawns a subagent with full tool access
129-
- The subagent can Read files, run Bash commands, use Grep, etc.
130-
- Returns a decision (approve/block) with reasoning
131-
- Significantly slower than command or prompt hooks (30-120 seconds)
132-
133-
### Supported Events
134-
135-
Only `Stop` and `SubagentStop` — agent hooks are too slow for PreToolUse or PostToolUse.
136-
137-
### When to Use
138-
139-
- Verification requires reading multiple files
140-
- Need to run commands and analyze output
141-
- Single-prompt evaluation is insufficient
142-
- Comprehensive completion criteria
118+
**Quick summary:** Agent hooks spawn a subagent with full tool access (Read, Bash, Grep, etc.) for multi-step verification. They're significantly slower (30-120 seconds) but more capable than command or prompt hooks. Only supported on `Stop` and `SubagentStop` events.
143119

144120
## Auto-Update Behavior
145121

plugins/plugin-dev/skills/plugin-structure/references/headless-ci-mode.md

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -45,18 +45,18 @@ If the skill has `user-invocable: false` and is loaded via plugin, Claude can st
4545
Auto-approve specific tools without interactive prompts:
4646

4747
```bash
48-
claude -p "Fix the bug" --allowedTools "Read,Write,Edit,Bash(git:*)"
48+
claude -p "Fix the bug" --allowedTools "Read,Write,Edit,Bash(git *)"
4949
```
5050

5151
**Permission rule syntax:**
5252

53-
| Pattern | Matches |
54-
| ---------------------- | ---------------------------------------------------------- |
55-
| `Read` | All Read tool calls |
56-
| `Bash(git:*)` | Bash commands starting with "git" (note: space before `*`) |
57-
| `mcp__*` | All MCP tool calls |
58-
| `mcp__plugin_myplug_*` | Tools from a specific plugin's MCP server |
59-
| `Write,Edit` | Multiple tools (comma-separated) |
53+
| Pattern | Matches |
54+
| ---------------------- | ------------------------------------------------------------ |
55+
| `Read` | All Read tool calls |
56+
| `Bash(git *)` | Bash commands starting with "git " (prefix match with space) |
57+
| `mcp__*` | All MCP tool calls |
58+
| `mcp__plugin_myplug_*` | Tools from a specific plugin's MCP server |
59+
| `Write,Edit` | Multiple tools (comma-separated) |
6060

6161
**Plugin design tip:** Document recommended `--allowedTools` values in your plugin README for CI usage.
6262

0 commit comments

Comments
 (0)