Skip to content

fix: make Bash tool validation rule contextual for workflow commands #101

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sjnims merged 1 commit into from
Dec 10, 2025
Merged

fix: make Bash tool validation rule contextual for workflow commands #101

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion .github/workflows/component-validation.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,8 @@ jobs:
- [ ] YAML frontmatter exists with `name`, `description`, `allowed-tools` fields
- [ ] `description` is 60 characters or fewer
- [ ] `allowed-tools` follows these rules:
- MUST use `Bash(gh:*)` not unrestricted `Bash` (security requirement)
- For simple commands needing only specific CLI operations: prefer Bash prefix patterns like `Bash(gh pr:*)`, `Bash(npm run:*)` (uses prefix matching with `:*` wildcard)
- Unrestricted `Bash` is acceptable for workflow/scaffolding commands that legitimately need filesystem operations (mkdir, git init, directory creation) - verify the command's stated purpose justifies broader access
- `Read` is always allowed (reading files is safe)
- `Write` is allowed ONLY if the command creates/exports files (e.g., status export)
- `AskUserQuestion` is always allowed (user interaction is safe)
Expand Down
Loading