Skip to content

fix: add Bash(git init:*) to create-marketplace allowed-tools#110

Merged
sjnims merged 1 commit intomainfrom
fix/109-add-bash-git-init-to-create-marketplace
Dec 11, 2025
Merged

fix: add Bash(git init:*) to create-marketplace allowed-tools#110
sjnims merged 1 commit intomainfrom
fix/109-add-bash-git-init-to-create-marketplace

Conversation

@sjnims
Copy link
Copy Markdown
Owner

@sjnims sjnims commented Dec 11, 2025

Description

Adds the missing Bash(git init:*) tool to the create-marketplace command's allowed-tools frontmatter. This tool was referenced in Phase 4's instruction to "Initialize git repo if creating new directory" but was not authorized in the frontmatter.

Type of Change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update (improvements to README, CLAUDE.md, or component docs)
  • Refactoring (code change that neither fixes a bug nor adds a feature)
  • Configuration change (changes to .markdownlint.json, plugin.json, etc.)

Component(s) Affected

  • Commands (/plugin-dev:*)
  • Skills (methodology and best practices)
  • Agents (requirements-assistant)
  • Hooks (UserPromptSubmit)
  • Documentation (README.md, CLAUDE.md, SECURITY.md)
  • Configuration (.markdownlint.json, plugin.json, marketplace.json)
  • Issue/PR templates
  • Other (please specify):

Motivation and Context

The create-marketplace command instructs Claude to initialize a git repository in Phase 4, but the Bash(git init:*) tool was not included in allowed-tools. This caused the command to either fail or prompt for additional permissions, breaking the guided workflow.

This was discovered during a comprehensive review of both plugin commands against Claude Code plugin command best practices and official documentation.

Fixes #109

How Has This Been Tested?

Test Configuration:

  • Verified YAML frontmatter syntax is valid
  • Ran markdownlint with no errors
  • Compared with create-plugin.md which correctly includes this tool

Test Steps:

  1. Ran markdownlint plugins/plugin-dev/commands/create-marketplace.md - passed
  2. Verified frontmatter structure matches create-plugin.md pattern
  3. Confirmed Bash(git init:*) is placed after Bash(mkdir:*) for logical grouping

Checklist

General

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas (if applicable)
  • My changes generate no new warnings or errors

Documentation

  • I have updated the documentation accordingly (README.md, CLAUDE.md, or component docs)
  • I have updated YAML frontmatter (if applicable)
  • I have verified all links work correctly

Markdown

  • I have run markdownlint and fixed all issues
  • My markdown follows the repository style (ATX headers, dash lists, fenced code blocks)
  • I have verified special HTML elements are properly closed (<example>, <commentary>, etc.)

Component-Specific Checks

Commands (if applicable)

  • Command uses imperative form ("Do X", not "You should do X")
  • Error handling is included for common failure modes
  • GitHub CLI commands are properly formatted
  • Success/failure messages are clear and helpful

Testing

  • I have tested the plugin locally with cc --plugin-dir plugins/plugin-dev
  • I have tested the full workflow (if applicable)
  • I have verified GitHub CLI integration works (if applicable)
  • I have tested in a clean repository (not my development repo)

Version Management (if applicable)

  • I have updated version numbers in both plugin.json and marketplace.json (if this is a release)
  • I have updated CHANGELOG.md with relevant changes

Additional Notes

This is a one-line fix that aligns create-marketplace.md with create-plugin.md, which correctly includes Bash(git init:*) in its allowed-tools.

Before:

allowed-tools: Read, Write, Edit, Grep, Glob, Bash(mkdir:*), TodoWrite, AskUserQuestion, Skill, Task

After:

allowed-tools: Read, Write, Edit, Grep, Glob, Bash(mkdir:*), Bash(git init:*), TodoWrite, AskUserQuestion, Skill, Task

🤖 Generated with Claude Code

The create-marketplace command's Phase 4 instructs Claude to "Initialize
git repo if creating new directory", but the allowed-tools frontmatter
was missing Bash(git init:*). This caused permission failures or prompts
when the command attempted to initialize a git repository.

This aligns create-marketplace.md with create-plugin.md, which correctly
includes this tool.

Fixes #109

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
@claude
Copy link
Copy Markdown

claude Bot commented Dec 11, 2025

Claude finished @sjnims's task in 1m 6s —— View job


PR Review: Add Bash(git init:*) to create-marketplace

Summary

Looks good - Ready to merge

This is a clean, focused fix that addresses a missing tool authorization in the create-marketplace command.


What's Good

  1. Correct Fix: The Bash(git init:*) tool is referenced in Phase 4 (line 160: "Initialize git repo if creating new directory") but was missing from the frontmatter. This PR adds it.

  2. Consistency: Now aligns with create-plugin.md (line 4), which correctly includes this tool in its allowed-tools.

  3. Proper Placement: The tool is logically placed after Bash(mkdir:*) in the list, maintaining coherent grouping of bash commands.

  4. Clean Implementation: Single-line change, no extraneous modifications.

  5. Markdown Linting: Passes markdownlint with no errors ✅

  6. Well-Documented: The PR description clearly explains the issue, fix, and testing approach.


Checklist Verification

All key items from the PR description are properly addressed:


Diff Analysis

-allowed-tools: Read, Write, Edit, Grep, Glob, Bash(mkdir:*), TodoWrite, AskUserQuestion, Skill, Task
+allowed-tools: Read, Write, Edit, Grep, Glob, Bash(mkdir:*), Bash(git init:*), TodoWrite, AskUserQuestion, Skill, Task

The change is minimal, targeted, and follows the exact pattern used in create-plugin.md.


Recommendation

Approve and merge. This fix:

  • Resolves a workflow-breaking permission issue
  • Maintains consistency across plugin commands
  • Follows established patterns
  • Requires no additional changes

@claude claude Bot added bug Something isn't working component:command Commands layer effort:small < 1 hour labels Dec 11, 2025
@sjnims sjnims merged commit 3714ae2 into main Dec 11, 2025
8 checks passed
@sjnims sjnims deleted the fix/109-add-bash-git-init-to-create-marketplace branch December 11, 2025 01:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working component:command Commands layer effort:small < 1 hour

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: create-marketplace command missing Bash(git init:*) in allowed-tools

1 participant