Skip to content

feat: move edge cases section outside code block in agent-creator#129

Merged
sjnims merged 1 commit intomainfrom
feat/127-move-edge-cases-outside-code-block
Dec 11, 2025
Merged

feat: move edge cases section outside code block in agent-creator#129
sjnims merged 1 commit intomainfrom
feat/127-move-edge-cases-outside-code-block

Conversation

@sjnims
Copy link
Copy Markdown
Owner

@sjnims sjnims commented Dec 11, 2025

Summary

Move edge cases from inside the output format code block to a standalone section, aligning agent-creator.md with the patterns used by plugin-validator.md and skill-reviewer.md.

Problem

Fixes #127

The agent-creator.md agent had its edge cases embedded inside the output format markdown code block (lines 182-188), while the other two agents have edge cases as standalone sections at the end of their system prompts.

This structural inconsistency:

  • Makes the agent-creator pattern different from its sibling agents
  • Could affect how the LLM processes edge case guidance (inside a code block may be treated as "example output" rather than "instructions to follow")

Solution

Moved the edge cases from inside the output format code block to a standalone **Edge Cases:** section after the code block, matching the pattern in:

  • plugin-validator.md:299-309
  • skill-reviewer.md:195-201

Alternatives Considered

  1. Leave as-is - The agent works correctly, but inconsistency could cause subtle issues
  2. Update the other agents - Could move their edge cases inside code blocks instead, but having edge cases as instructions (outside code blocks) is more semantically correct

Changes

  • plugins/plugin-dev/agents/agent-creator.md: Close code block after "Next Steps" section, add standalone edge cases section

Testing

  • Linting passes
  • Structure matches plugin-validator and skill-reviewer patterns

🤖 Generated with Claude Code

@sjnims @claude
feat: move edge cases section outside code block in agent-creator
255adbc 
Move the edge cases from inside the output format code block to a
standalone section at the end of the system prompt, matching the
pattern used by plugin-validator.md and skill-reviewer.md.

This structural consistency ensures edge cases are treated as
instructions to follow rather than example output content.

Fixes #127

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
@sjnims sjnims mentioned this pull request Dec 11, 2025
Closed
@claude
Copy link
Copy Markdown

claude Bot commented Dec 11, 2025 •
edited
Loading

Claude finished @sjnims's task in 1m 24s —— View job

PR Review: Move Edge Cases Outside Code Block

Summary

✅ Looks good - This is a well-reasoned structural improvement that enhances consistency across agents.

What's Good

  1. Strong Alignment with Sibling Agents: The change perfectly matches the pattern used in plugin-validator.md:299-309 and skill-reviewer.md:195-201, creating architectural consistency across all three agents.

  2. Semantic Correctness: Moving edge cases outside the output format code block is the right call. When edge cases are inside a markdown code block (especially one showing output format), the LLM may treat them as "example output" rather than "instructions to follow." This change ensures they're processed as behavioral guidance.

  3. Clean Implementation: The diff is minimal and surgical:

    • Closes the code block after "Next Steps" section
    • Adds proper spacing with blank line
    • Maintains all edge case content unchanged
    • No unintended modifications

  4. Quality Metadata: The PR description clearly explains the problem, solution, and rationale. The commit message follows conventions and references the issue properly.

Markdown Linting

✅ No issues found

Ran markdownlint --config .markdownlint.json on plugins/plugin-dev/agents/agent-creator.md - all checks pass.

Checklist Verification

✅ Agent Structure: Frontmatter is correct (name, description, model, color, tools, skills all valid)

✅ Triggering Examples: The 4 <example> blocks show both explicit requests and proactive triggering scenarios

✅ Pattern Consistency: Now matches the pattern in:

  • plugin-validator.md (lines 299-309): Edge cases section after output format
  • skill-reviewer.md (lines 195-201): Edge cases section after output format

✅ Content Preservation: All 6 edge cases preserved with identical wording

✅ Documentation: PR description adequately explains the change; no README/CLAUDE.md updates needed for this internal structural improvement

Suggestions

None - this is a straightforward improvement with no issues identified.

Overall Assessment

Approved - This PR improves architectural consistency and semantic correctness without introducing any issues. The change is minimal, well-tested (linting passes), and aligns the three agents to use the same structural pattern for edge cases.

@claude claude Bot added refactor Code restructuring without behavior change component:agent Agents layer effort:small < 1 hour labels Dec 11, 2025
@sjnims sjnims self-assigned this Dec 11, 2025
@sjnims sjnims merged commit 180b0db into main Dec 11, 2025
8 checks passed
@sjnims sjnims deleted the feat/127-move-edge-cases-outside-code-block branch December 11, 2025 03:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@sjnims sjnims

Labels

component:agent Agents layer effort:small < 1 hour refactor Code restructuring without behavior change

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Feature]: Move edge cases section outside code block in agent-creator agent

1 participant

@sjnims