Skip to content

docs: fix second-person usage in mcp-integration skill#81

Merged
sjnims merged 1 commit intomainfrom
docs/79-fix-second-person-mcp-integration
Dec 9, 2025
Merged

docs: fix second-person usage in mcp-integration skill#81
sjnims merged 1 commit intomainfrom
docs/79-fix-second-person-mcp-integration

Conversation

@sjnims
Copy link
Copy Markdown
Owner

@sjnims sjnims commented Dec 9, 2025

Summary

Fix second-person pronoun usage ("you're") in the mcp-integration skill reference file to follow skill writing style guidelines requiring imperative form.

Problem

Fixes #79

The skill reference file used second-person ("Ensure you're authenticated") in instructional text at line 409, violating the skill development guidelines which require imperative/infinitive form.

Solution

Changed "Ensure you're authenticated to Asana before running this command." to "Ensure authentication to Asana before running this command." using Option 1 from the issue.

Alternatives Considered

  • Option 2 (passive): "Authentication to Asana is required before running this command." - More natural but less consistent with imperative style used elsewhere.

Changes

  • plugins/plugin-dev/skills/mcp-integration/references/tool-usage.md: Line 409 updated to imperative form

Testing

  • Markdownlint passes
  • Change follows skill writing style guidelines

🤖 Generated with Claude Code

Change "Ensure you're authenticated" to imperative form
"Ensure authentication" to follow skill writing style guidelines.

Fixes #79

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
@claude
Copy link
Copy Markdown

claude Bot commented Dec 9, 2025

Claude finished @sjnims's task —— View job


Summary

Looks good - This is a clean, focused fix that correctly addresses issue #79.

What's Good

Style Compliance: The change correctly fixes the second-person pronoun usage ("you're") to imperative form ("authentication"), which aligns perfectly with the skill writing style guidelines in CLAUDE.md:62 and the skill-development skill (plugins/plugin-dev/skills/skill-development/SKILL.md:117).

Minimal Scope: The PR makes exactly one focused change to address the issue - no scope creep, no unnecessary modifications.

Quality Checks:

  • ✅ Markdownlint passes with no errors
  • ✅ Change is in a skill reference file (references/tool-usage.md), which should follow imperative/infinitive form per the guidelines
  • ✅ Commit message follows conventional commits format
  • ✅ Issue reference included in PR description and commit message

Context Preserved: The change from "Ensure you're authenticated to Asana" to "Ensure authentication to Asana" maintains the meaning while removing the second-person pronoun. The imperative form ("Ensure authentication") is consistent with the guideline: "Use imperative/infinitive form ('To create X, do Y'), not second person ('You should...')"

Checklist Verification

Recommendation

This PR is ready to merge. The change is correct, minimal, and addresses the documented style violation without introducing any new issues.


@claude claude Bot added documentation Improvements or additions to documentation component:skill Skills layer effort:small < 1 hour labels Dec 9, 2025
@sjnims sjnims merged commit 0f88339 into main Dec 9, 2025
8 checks passed
@sjnims sjnims deleted the docs/79-fix-second-person-mcp-integration branch December 9, 2025 04:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

component:skill Skills layer documentation Improvements or additions to documentation effort:small < 1 hour

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Docs]: Fix second-person usage in mcp-integration skill reference

1 participant