Skip to content

docs(plugin-settings): fix allowed-tools syntax to use comma-separated format#83

Merged
sjnims merged 1 commit intomainfrom
docs/82-fix-allowed-tools-syntax
Dec 9, 2025
Merged

docs(plugin-settings): fix allowed-tools syntax to use comma-separated format#83
sjnims merged 1 commit intomainfrom
docs/82-fix-allowed-tools-syntax

Conversation

@sjnims
Copy link
Copy Markdown
Owner

@sjnims sjnims commented Dec 9, 2025

Summary

Fix allowed-tools frontmatter syntax in the plugin-settings skill to use the official comma-separated string format instead of JSON array syntax.

Problem

Fixes #82

The allowed-tools field in two files used incorrect JSON array syntax ["Tool1", "Tool2"] instead of the official comma-separated format Tool1, Tool2 per Claude Code documentation.

Solution

Changed the syntax in both files to match official documentation:

File Before After
SKILL.md:105 allowed-tools: ["Read", "Bash"] allowed-tools: Read, Bash
examples/create-settings-command.md:3 allowed-tools: ["Write", "AskUserQuestion"] allowed-tools: Write, AskUserQuestion

Alternatives Considered

None - the fix is unambiguous and directly specified by official Claude Code documentation.

Changes

  • plugins/plugin-dev/skills/plugin-settings/SKILL.md: Fixed allowed-tools syntax on line 105
  • plugins/plugin-dev/skills/plugin-settings/examples/create-settings-command.md: Fixed allowed-tools syntax on line 3

Testing

  • Linting passes (markdownlint)
  • No code changes requiring tests

🤖 Generated with Claude Code

…d format

Changed allowed-tools from JSON array syntax to official comma-separated
string format per Claude Code documentation.

Fixes #82

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
@claude
Copy link
Copy Markdown

claude Bot commented Dec 9, 2025

Claude finished @sjnims's task —— View job


PR Review Complete ✓

  • Get PR diff to understand changes
  • Read changed files for context
  • Run markdownlint on changed .md files
  • Review against plugin component criteria
  • Post review summary

Summary

Looks good - This is a straightforward documentation fix that corrects the allowed-tools frontmatter syntax.

What's Good

Correct syntax change: The PR properly converts from incorrect JSON array syntax ["Tool1", "Tool2"] to the official comma-separated format Tool1, Tool2 as specified in Claude Code documentation.

Comprehensive fix: Both occurrences in the plugin-settings skill have been corrected:

  • SKILL.md:105 - Example command frontmatter
  • examples/create-settings-command.md:3 - Command frontmatter

Clean markdown: Both files pass markdownlint validation with no issues.

Accurate PR description: The PR clearly documents the problem, solution, and affected files with specific line numbers.

Proper issue linkage: Fixes #82 is correctly referenced.

Checklist Verification

  • ✓ Frontmatter syntax is correct per Claude Code documentation
  • ✓ All changed .md files pass markdownlint
  • ✓ Changes are limited to the documented issue scope
  • ✓ No unrelated modifications introduced

Recommendation

Approve and merge - This PR addresses a documentation bug with the correct fix. No changes needed.


@sjnims sjnims self-assigned this Dec 9, 2025
@claude claude Bot added documentation Improvements or additions to documentation component:skill Skills layer effort:small < 1 hour labels Dec 9, 2025
@sjnims sjnims merged commit 88c6498 into main Dec 9, 2025
8 checks passed
@sjnims sjnims deleted the docs/82-fix-allowed-tools-syntax branch December 9, 2025 04:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

component:skill Skills layer documentation Improvements or additions to documentation effort:small < 1 hour

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Docs]: Fix incorrect allowed-tools syntax in plugin-settings skill

1 participant