Skip to content

docs: fix second-person writing style in marketplace-structure skill#96

Merged
sjnims merged 1 commit intomainfrom
docs/94-fix-second-person-writing-style
Dec 10, 2025
Merged

docs: fix second-person writing style in marketplace-structure skill#96
sjnims merged 1 commit intomainfrom
docs/94-fix-second-person-writing-style

Conversation

@sjnims
Copy link
Copy Markdown
Owner

@sjnims sjnims commented Dec 10, 2025

Summary

Single-word fix to maintain imperative writing style in the marketplace-structure skill's distribution-patterns reference document.

Problem

Fixes #94

The skill-development best practices require imperative/infinitive form, not second person. Line 299 of distribution-patterns.md contained "you have access" which violated this guideline.

Solution

Changed "ensure repository is public or you have access" to "ensure repository is public or access is available".

This maintains the imperative verb ("ensure") while removing the second-person pronoun, consistent with the writing style used throughout the rest of the skill.

Alternatives Considered

  • "ensure repository is public or appropriate access exists" - More verbose, unnecessary
  • "ensure repository accessibility" - Loses clarity about public vs private repos

The chosen fix is minimal and maintains the original sentence structure.

Changes

  • plugins/plugin-dev/skills/marketplace-structure/references/distribution-patterns.md: Line 299 - "you have access" → "access is available"

Testing

  • markdownlint passes
  • No other files affected

🤖 Generated with Claude Code

@sjnims @claude
docs: fix second-person writing style in marketplace-structure skill
4b82b6a 
Change "you have access" to "access is available" in distribution-patterns.md
to maintain imperative/infinitive form per skill-development best practices.

Fixes #94

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
@sjnims sjnims mentioned this pull request Dec 10, 2025
Closed
7 tasks
@claude
Copy link
Copy Markdown

claude Bot commented Dec 10, 2025 •
edited
Loading

Claude finished @sjnims's task in 1m 11s —— View job

Reviewing PR #96

Todo List

  • Get PR diff to understand changes
  • Read the changed file for context
  • Run markdownlint on changed files
  • Review against writing style guidelines
  • Post comprehensive review feedback

Summary

✅ Looks good - This is a clean, focused fix that properly addresses the writing style issue.

What's Good

  • Precise fix: The change correctly removes second-person pronoun "you" while maintaining the imperative voice ("ensure")
  • Maintains clarity: "access is available" is clear and unambiguous - it's obvious this refers to having access to private repositories
  • Minimal scope: Single-word change that doesn't introduce unnecessary modifications
  • Follows guidelines: Aligns with CLAUDE.md requirement for imperative/infinitive form in skill documentation
  • Clean markdown: markdownlint passes with no issues
  • Well-documented PR: Clear explanation of the problem, solution, and alternatives considered

Markdown Linting

✅ No issues found - markdownlint passed successfully

Checklist Verification

  • ✅ Writing style: Changed from second-person ("you have") to impersonal passive ("access is available")
  • ✅ Imperative voice maintained: "ensure" verb retained
  • ✅ Markdown quality: No linting errors
  • ✅ Context preserved: Meaning unchanged, clarity maintained
  • ✅ Minimal change: Only the necessary word modified
  • ✅ Consistency: Matches style used throughout the rest of the skill

Recommendation

Approve and merge - This PR successfully fixes issue #94 and is ready to merge.

@sjnims sjnims self-assigned this Dec 10, 2025
@claude claude Bot added documentation Improvements or additions to documentation component:skill Skills layer effort:small < 1 hour labels Dec 10, 2025
@sjnims sjnims merged commit 2644125 into main Dec 10, 2025
8 checks passed
@sjnims sjnims deleted the docs/94-fix-second-person-writing-style branch December 10, 2025 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@sjnims sjnims

Labels

component:skill Skills layer documentation Improvements or additions to documentation effort:small < 1 hour

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Docs]: Fix second-person writing style in marketplace-structure skill

1 participant

@sjnims