[-]: highLightPadding 반영 및 overlay 위치 보정#7
Merged
sjsjsj1246 merged 1 commit intoMar 24, 2026
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
packages/main coverage
|
sjsjsj1246
deleted the
codex/add-highlight-padding-and-overlay-click-behavior
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
변경 사항
highLightPadding기본값을 8px로 두고 highlight rect 계산에 실제 반영했습니다.box-sizing: border-box기준으로 정리하고 padding에 맞춰 border radius를 조정했습니다.테스트 결과
pnpm -C packages/main test통과pnpm build통과pnpm -F @react-tutorial-overlay/document build통과남은 리스크
window.scrollX/Y를 사용하므로, 깊은 스크롤 컨테이너 환경에 대한 별도 보강은 이번 범위에 포함하지 않았습니다.