Conversation
Fix DOCKER_LVMPY_STREAM param in update_meta for mirage ops
Add prepare_block_device to mirage init and update
Unmount datadir in init/update/mirage for mirage boot
Fix mirage update boot cmd
Fixed update_images function to use NodeType correctly
Added `info` command to mirage boot and mirage node
Add mirage-* branches to build pipeline
…de-cli into add-cleanup-commands-for-skale-nodes
…ale-nodes Add cleanup commands for skale nodes
badrogger
previously approved these changes
Nov 18, 2025
Merge changes develop fair
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces significant updates to the build, test, and release workflows, adds new Fair node CLI functionality, and refactors several CLI modules for clarity and maintainability. It also updates project instructions and configuration files to align with new standards and practices.
Workflow and Release Process Improvements:
.github/workflows/publish.ymlto support building and publishing bothskaleandfairbinaries, with improved asset naming, checksum generation, and use of newer GitHub Actions versions. The build matrix and steps have been streamlined and generalized for future extensibility. [1] [2] [3] [4].github/workflows/test.ymlto userufffor linting instead offlake8, and added steps to build and check bothskaleandfairbinaries. This ensures consistent formatting and that both build types are tested. [1] [2]CLI Enhancements and Refactoring:
node_cli/cli/fair_boot.pywith commands for Fair node boot phase operations, including info, init, register, signature, and update functionalities.node_cli/cli/validate.pytonode_cli/cli/chain.py, replacing ABI validation commands with Fair chain record and check commands, and updating copyright years. [1] [2]node_cli/cli/exit.pyto use a safer text loading method, improved option formatting, and streamlined command definitions for better maintainability. [1] [2] [3] [4]Configuration and Documentation Updates:
.flake8configuration and updated.github/copilot-instructions.mdto clarify coding standards, linting, and testing procedures. [1] [2]Version and Submodule Updates:
3.2.0innode_cli/cli/__init__.py.helper-scriptssubmodule to the latest commit.