Skip to content

SS Adds ability to use unsafe suppress alert option for iOS only#109

Open
NoodleOfDeath wants to merge 1 commit into
skb1129:masterfrom
NoodleOfDeath:master
Open

SS Adds ability to use unsafe suppress alert option for iOS only#109
NoodleOfDeath wants to merge 1 commit into
skb1129:masterfrom
NoodleOfDeath:master

Conversation

@NoodleOfDeath

@NoodleOfDeath NoodleOfDeath commented May 18, 2024

Copy link
Copy Markdown

Need to

  • run some tests first, but this allow devs to use the unsafe method that does not force an alert popup.
  • I need to also put it inside of a try catch
  • update android so the code doesnt break

@NoodleOfDeath
NoodleOfDeath marked this pull request as ready for review May 18, 2024 13:58
@NoodleOfDeath
NoodleOfDeath force-pushed the master branch 2 times, most recently from ce8b866 to ba104f2 Compare May 18, 2024 14:03
@bibhuti9

bibhuti9 commented Oct 3, 2024

Copy link
Copy Markdown

@NoodleOfDeath Thanks for this feature
Please add "SS" in this pull request to clarify the "suppress alert option" for others.

@NoodleOfDeath NoodleOfDeath changed the title Adds ability to use unsafe suppress alert option for iOS only SS Adds ability to use unsafe suppress alert option for iOS only Oct 3, 2024
@NoodleOfDeath

Copy link
Copy Markdown
Author

@NoodleOfDeath Thanks for this feature Please add "SS" in this pull request to clarify the "suppress alert option" for others.

As the comment? Or in the title? Or both?

@bibhuti9

bibhuti9 commented Oct 3, 2024

Copy link
Copy Markdown

I mean, it would be great if you could add the feature SS in the PR description.

@NoodleOfDeath

Copy link
Copy Markdown
Author

I mean, it would be great if you could add the feature SS in the PR description.

SS as in a screenshot?

@NoodleOfDeath

NoodleOfDeath commented Oct 3, 2024

Copy link
Copy Markdown
Author

The feature just lets you assign the icon without a popup alert... nothing to really to screenshot?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants