external-styles-include#155
Open
artreaktor-niks wants to merge 1 commit into
Open
Conversation
koskinpark
reviewed
Apr 27, 2022
| --- | ||
| /color/*.css | ||
| dist/**/*.css | ||
| *_external.css No newline at end of file |
Collaborator
There was a problem hiding this comment.
It's redundant, probably disabling dist/**/*.css will be already enough. Please test
Collaborator
Author
There was a problem hiding this comment.
It is because of lint checking file on "Drupal/src" & storybook linter check files of external libraries css.
artreaktor-niks
force-pushed
the
external-styles-include
branch
from
May 2, 2022 07:42
617a7d1 to
c2866ed
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Temporary way to include external library styles with linter exclude.
Target to gather all component styles in one place. In this case on the storybook component.
In this temporary way - include CSS file from a library inside a separate file on the storybook side.
Than include this file separately - on storybook, and on Drupal side.
For the linter - added exclusion for the files that have names ending on *_external.css