Add textFieldContentPadding modifier for compact text fields#470
Open
IT-Guy007 wants to merge 2 commits into
Open
Add textFieldContentPadding modifier for compact text fields#470IT-Guy007 wants to merge 2 commits into
IT-Guy007 wants to merge 2 commits into
Conversation
Adds a textFieldContentPadding(_:) View modifier (plus a bridged variant) that overrides the OutlinedTextField content padding. When set, TextField renders via BasicTextField + OutlinedTextFieldDefaults.DecorationBox so the padding — and therefore the field height — is honored; the default OutlinedTextField rendering path is unchanged.
Author
|
@marcprux ready for review |
Member
|
Do you happen to have a screenshot of how this looks? |
Author
|
I do not, I tested it locally with skip-fuse-ui the default padding was gone |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a textFieldContentPadding(_:) View modifier (plus a bridged variant) that overrides the OutlinedTextField content padding. When set, TextField renders via BasicTextField + OutlinedTextFieldDefaults.DecorationBox so the padding — and therefore the field height — is honored; the default OutlinedTextField rendering path is unchanged.
Thank you for contributing to the Skip project! Please review the contribution guide at https://skip.dev/docs/contributing/ for advice and guidance on making high-quality PRs.
Use this space to describe your change and add any labels (bug, enhancement, documentation, etc.) to help categorize your contribution.
Skip Pull Request Checklist:
swift testskip-fuse-ai will also get a pr