Add opt-out --no-check-devices flag for skip doctor and checkup

Author: dfabulich

Sources/SkipBuild/Commands/CheckupCommand.swift

@@ -52,6 +52,9 @@ This command performs a full system checkup to ensure that Skip can create and b
     @Flag(inversion: .prefixedNo, help: ArgumentHelp("Fail immediately when an error occurs"))
     var failFast: Bool = true
 
+    @Flag(inversion: .prefixedNo, help: ArgumentHelp("Check for connected Android devices/emulators", valueName: "check-devices"))
+    var checkDevices: Bool = true
+
     @Option(name: [.long], help: ArgumentHelp("Name of checkup project", valueName: "name"))
     var projectName: String = "hello-skip"
 
@@ -99,7 +102,7 @@ This command performs a full system checkup to ensure that Skip can create and b
     }
 
     func runCheckup(with out: MessageQueue) async throws {
-        let hasAndroidDevices = try await runDoctor(checkNative: isNative, with: out)
+        let hasAndroidDevices = try await runDoctor(checkNative: isNative, checkDevices: checkDevices, with: out)
 
         @Sendable func buildSampleProject(packageResolvedURL: URL? = nil, launchAndroid: Bool) async throws -> (projectURL: URL, project: AppProjectLayout, artifacts: [URL: String?]) {
             let primary = packageResolvedURL == nil

Sources/SkipBuild/Commands/DoctorCommand.swift

@@ -34,11 +34,14 @@ This command will check for system configuration and prerequisites. It is a subs
     @Flag(inversion: .prefixedNo, help: ArgumentHelp("Fail immediately when an error occurs"))
     var failFast: Bool = false
 
+    @Flag(inversion: .prefixedNo, help: ArgumentHelp("Check for connected Android devices/emulators", valueName: "check-devices"))
+    var checkDevices: Bool = true
+
     func performCommand(with out: MessageQueue) async {
         await withLogStream(with: out) {
             await out.yield(MessageBlock(status: nil, "Skip Doctor"))
 
-            _ = try await runDoctor(checkNative: self.native, with: out)
+            _ = try await runDoctor(checkNative: self.native, checkDevices: self.checkDevices, with: out)
             let latestVersion = await checkSkipUpdates(with: out)
             if let latestVersion = latestVersion, latestVersion != skipVersion {
                 await out.yield(MessageBlock(status: .warn, "A new version is Skip (\(latestVersion)) is available to update with: skip upgrade"))
@@ -51,8 +54,8 @@ extension ToolOptionsCommand where Self : StreamingCommand {
     // TODO: check license validity: https://github.com/skiptools/skip/issues/388
 
     /// Runs the `skip doctor` command and stream the results to the messenger.
-    /// Returns true if Android devices/emulators are attached, false otherwise.
-    func runDoctor(checkNative: Bool, with out: MessageQueue) async throws -> Bool {
+    /// Returns true if Android devices/emulators are attached, false otherwise (or if checkDevices is false).
+    func runDoctor(checkNative: Bool, checkDevices: Bool = true, with out: MessageQueue) async throws -> Bool {
         /// Invokes the given command and attempts to parse the output against the given regular expression pattern to validate that it is a semantic version string
         func checkVersion(title: String, cmd: [String], min: Version? = nil, pattern: String, watch: Bool = false, hint: String? = nil) async throws {
 
@@ -145,21 +148,23 @@ extension ToolOptionsCommand where Self : StreamingCommand {
         try await checkVersion(title: "Android Debug Bridge version", cmd: ["adb", "version"], min: Version("1.0.40"), pattern: "version ([0-9.]+)")
 
         var hasAndroidDevices = false
-        _ = await outputOptions.monitor(with: out, "Android devices", watch: false, resultHandler: { result in
-            do {
-                let devices = try result?.get() ?? []
-                hasAndroidDevices = !devices.isEmpty
-                if devices.isEmpty {
-                    return (result, MessageBlock(status: .warn, "No Android devices running. Xcode builds will fail until you attach a device, launch an emulator in Android Studio, or run: skip android emulator launch"))
-                } else {
-                    return (result, MessageBlock(status: .pass, "Android devices: \(devices.count) connected"))
+        if checkDevices {
+            _ = await outputOptions.monitor(with: out, "Android devices", watch: false, resultHandler: { result in
+                do {
+                    let devices = try result?.get() ?? []
+                    hasAndroidDevices = !devices.isEmpty
+                    if devices.isEmpty {
+                        return (result, MessageBlock(status: .warn, "No Android devices running. Xcode builds will fail until you attach a device, launch an emulator in Android Studio, or run: skip android emulator launch"))
+                    } else {
+                        return (result, MessageBlock(status: .pass, "Android devices: \(devices.count) connected"))
+                    }
+                } catch {
+                    return (result, MessageBlock(status: .fail, "Android devices: error running adb devices"))
                 }
-            } catch {
-                return (result, MessageBlock(status: .fail, "Android devices: error running adb devices"))
-            }
-        }, monitorAction: { _ in
-            try await getAndroidDevices()
-        })
+            }, monitorAction: { _ in
+                try await getAndroidDevices()
+            })
+        }
 
         if let androidHome = ProcessInfo.androidHome {
             let exists = FileManager.default.fileExists(atPath: androidHome)