I don't see the feature as strictly necessary but would be okay with it being added. @ottonemo @thomasjpfan any opinions on that?

If this change is made, I would suggest to keep the default as is. Also, @BenAjayiObe, please have a look at this function we introduced:

skorch/skorch/utils.py

Lines 128 to 136 in 09be626

    
           def to_device(X, device): 
        
               """Generic function to move module output(s) to a device. 
        
               Deals with X being a torch tensor or a tuple of torch tensors. 
        
               """ 
        
               if isinstance(X, tuple): 
        
                   return tuple(x.to(device) for x in X) 
        
               return X.to(device)

The functionality should be added there. However, this function is not used consistently in our codebase each time we cast, this would need to be fixed.

What I did wonder: Should we also allow the option to set device to None (or 'none'?) so as to prevent any kind of casting?

	def to_device(X, device):
	"""Generic function to move module output(s) to a device.

	Deals with X being a torch tensor or a tuple of torch tensors.

	"""
	if isinstance(X, tuple):
	return tuple(x.to(device) for x in X)
	return X.to(device)

device='auto' should select the fastest possible device #576

Description

Metadata

Metadata

Assignees

Labels

Type

Fields

Projects

Milestone

Relationships

Development

Issue actions