Skip to content

Commit c8a000b

Browse files
committed
Pushing the docs to dev/ for branch: main, commit 8c4a8b453c4c24fa6204ab30224d0327c04ed747
1 parent b4c2159 commit c8a000b

225 files changed

Lines changed: 42970 additions & 42903 deletions

File tree

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

dev/CONTRIBUTING.html

Lines changed: 31 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -899,6 +899,36 @@ <h2>Submitting your code<a class="headerlink" href="#submitting-your-code" title
899899
<p>Once you have pushed your commits to your remote repository, you can submit
900900
a PR by clicking the “Compare &amp; pull request” button on GitHub,
901901
targeting the skrub repository.</p>
902+
<section id="updating-the-changelog">
903+
<h3>Updating the changelog<a class="headerlink" href="#updating-the-changelog" title="Link to this heading">#</a></h3>
904+
<p>Any user-facing change to the codebase needs to be reported in the changelog,
905+
found in the <code class="docutils literal notranslate"><span class="pre">CHANGES.rst</span></code> file in the root of the repository. A user-facing
906+
change is any change to a functionality of skrub that users are expected to interact
907+
with: for example, adding or removing a parameter, adding a new transformer,
908+
deprecating a function, etc.</p>
909+
<p>Changes made in the test suite, or changes made in the
910+
private parts of the library, should not be reported, unless they bring some benefit
911+
to the user (such as performance improvements). Normally, changes made to the
912+
documentation, such as typo or formatting fixes, are not reported either, while
913+
new examples usually can be added.
914+
Depending on the nature of the PR, a maintainer may add the “no
915+
changelog needed” label to skip the corresponding check if a changelog entry isn’t
916+
relevant.</p>
917+
<p>Changelog entries need to follow a specific format: the change should be described
918+
in sufficient detail for users to understand how they may be affected, and the
919+
entry must list both the PR number and the GitHub username of the author(s) of the
920+
PR.</p>
921+
<p>Here is an example:</p>
922+
<div class="highlight-bash notranslate"><div class="highlight"><pre><span></span><span class="w"> </span>-<span class="w"> </span>:meth:<span class="sb">`</span>DataOp.skb.apply<span class="sb">`</span><span class="w"> </span>now<span class="w"> </span>allows<span class="w"> </span>passing<span class="w"> </span>extra<span class="w"> </span>named<span class="w"> </span>arguments<span class="w"> </span>to<span class="w"> </span>the
923+
estimator<span class="err">&#39;</span>s<span class="w"> </span>methods<span class="w"> </span>through<span class="w"> </span>the<span class="w"> </span>parameters<span class="w"> </span><span class="sb">``</span>fit_kwargs<span class="sb">``</span>,<span class="w"> </span><span class="sb">``</span>predict_kwargs<span class="sb">``</span>
924+
etc.<span class="w"> </span>:pr:<span class="sb">`</span><span class="m">1642</span><span class="sb">`</span><span class="w"> </span>by<span class="w"> </span>:user:<span class="sb">`</span>Jérôme<span class="w"> </span>Dockès<span class="w"> </span>&lt;jeromedockes&gt;<span class="sb">`</span>.
925+
</pre></div>
926+
</div>
927+
<p>The PR number is reported with the directive <code class="docutils literal notranslate"><span class="pre">:pr:`NUMBER`</span></code>, and the author
928+
of the PR uses the directive <code class="docutils literal notranslate"><span class="pre">:user:`AUTHOR</span> <span class="pre">NAME</span> <span class="pre">&lt;GITHUB</span> <span class="pre">HANDLE&gt;`</span></code>.</p>
929+
<p>Missing changelog entries, or changelog entries that do not follow the format,
930+
will fail the changelog check in the CI.</p>
931+
</section>
902932
<section id="continuous-integration-ci">
903933
<h3>Continuous Integration (CI)<a class="headerlink" href="#continuous-integration-ci" title="Link to this heading">#</a></h3>
904934
<p>After creating your PR, CI tools will run proceed to run all the tests on all
@@ -1052,6 +1082,7 @@ <h4>Integration<a class="headerlink" href="#integration" title="Link to this hea
10521082
</ul>
10531083
</li>
10541084
<li class="toc-h2 nav-item toc-entry"><a class="reference internal nav-link" href="#submitting-your-code">Submitting your code</a><ul class="nav section-nav flex-column">
1085+
<li class="toc-h3 nav-item toc-entry"><a class="reference internal nav-link" href="#updating-the-changelog">Updating the changelog</a></li>
10551086
<li class="toc-h3 nav-item toc-entry"><a class="reference internal nav-link" href="#continuous-integration-ci">Continuous Integration (CI)</a><ul class="nav section-nav flex-column">
10561087
<li class="toc-h4 nav-item toc-entry"><a class="reference internal nav-link" href="#integration">Integration</a></li>
10571088
</ul>
Binary file not shown.
0 Bytes
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.

0 commit comments

Comments
 (0)