allow passing additional arguments to scorers in dataops#1995
Merged
Conversation
a8a4d92 to
7435464
Compare
7435464 to
fb7e23f
Compare
rcap107
reviewed
Apr 8, 2026
Member
rcap107
left a comment
There was a problem hiding this comment.
Thanks a lot for this PR @jeromedockes, this will be very useful. I left a few comments for clairification (as usual), and a few small cosmetic changes. I think the main thing that is missing is an entry in the API reference. We might also want to update one of the examples in the gallery with the new method at some point.
Member
Author
|
thanks for the review @rcap107 , I checked the links and they should be good now |
rcap107
approved these changes
Apr 9, 2026
Member
rcap107
left a comment
There was a problem hiding this comment.
Looks good to me! Thanks a lot @jeromedockes
Member
Author
|
thanks for the reviews :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We can now call
.skb.with_scoringto define which scorer should be used and pass additional arguments to it (such as sample weights). those can be dataops (ie sample weights are computed dynamically from the inputs)