Fixed issues comma separated GUID values

Until now, the thwo methods supported query strings like "guid1=a&guid2=b", but not "guids=a,b". With this commit, both scenarios are now supported.

Author: abjerner

src/Skybrud.Essentials.AspNetCore/QueryStringExtensions.cs

@@ -405,7 +405,7 @@ public static Guid GetGuid(this IQueryCollection? query, string key, Guid fallba
         /// <param name="key">The key of the query string component.</param>
         /// <returns>An instance of <see cref="List{Guid}"/>.</returns>
         public static Guid[] GetGuidArray(this IQueryCollection? query, string key) {
-            return query is null ? Array.Empty<Guid>() : query.GetGuidList(key).ToArray();
+            return query?[key].ToGuidArray() ?? Array.Empty<Guid>();
         }
 
         /// <summary>
@@ -415,18 +415,7 @@ public static Guid[] GetGuidArray(this IQueryCollection? query, string key) {
         /// <param name="key">The key of the query string component.</param>
         /// <returns>An instance of <see cref="List{Guid}"/>.</returns>
         public static List<Guid> GetGuidList(this IQueryCollection? query, string key) {
-
-            List<Guid> guids = new();
-
-            StringValues? values = query?[key];
-            if (values is null) return guids;
-
-            foreach (string? value in values) {
-                if (StringUtils.TryParseGuid(value, out Guid guid)) guids.Add(guid);
-            }
-
-            return guids;
-
+            return query?[key].ToGuidList() ?? new List<Guid>();
         }
 
         /// <summary>

src/Skybrud.Essentials.AspNetCore/StringValuesExtensions.cs

@@ -189,6 +189,24 @@ public static Guid ToGuid(this StringValues values, Guid fallback) {
             return StringUtils.TryParseGuid(str, out Guid? result) ? result : null;
         }
 
+        /// <summary>
+        /// Parses the specified array of string <paramref name="values"/> into a <see cref="Guid"/> array.
+        /// </summary>
+        /// <param name="values">The string values.</param>
+        /// <returns>An array of <see cref="Guid"/>.</returns>
+        public static Guid[] ToGuidArray(this StringValues values) {
+            return values.SelectMany(StringUtils.ParseGuidArray).ToArray();
+        }
+
+        /// <summary>
+        /// Parses the specified array of string <paramref name="values"/> into a <see cref="Guid"/> list.
+        /// </summary>
+        /// <param name="values">The string values.</param>
+        /// <returns>A list of <see cref="Guid"/>.</returns>
+        public static List<Guid> ToGuidList(this StringValues values) {
+            return values.SelectMany(StringUtils.ParseGuidList).ToList();
+        }
+
     }
 
 }

src/TestProject1/QueryStringTests.cs

@@ -60,31 +60,33 @@ public void GetGuidOrNull() {
         public void GetGuidArray() {
 
             IQueryCollection query = new QueryCollection(new Dictionary<string, StringValues> {
-                {"guids", new StringValues(new[] { "7ce565ca-3dfe-4bc8-9166-4c4a5d1a9cbb", "a11c5663-d025-49be-93d7-876226dfd9b1", "nope", null })}
+                {"guids", new StringValues(new[] { "7ce565ca-3dfe-4bc8-9166-4c4a5d1a9cbb,8a2a3f66-898c-4b1e-8db7-efb8c08d4669", "a11c5663-d025-49be-93d7-876226dfd9b1", "nope", null })}
             });
 
             var guids = query.GetGuidArray("guids");
 
-            Assert.AreEqual(2, guids.Length);
+            Assert.AreEqual(3, guids.Length);
 
             Assert.AreEqual("7ce565ca-3dfe-4bc8-9166-4c4a5d1a9cbb", guids[0].ToString());
-            Assert.AreEqual("a11c5663-d025-49be-93d7-876226dfd9b1", guids[1].ToString());
+            Assert.AreEqual("8a2a3f66-898c-4b1e-8db7-efb8c08d4669", guids[1].ToString());
+            Assert.AreEqual("a11c5663-d025-49be-93d7-876226dfd9b1", guids[2].ToString());
 
         }
 
         [TestMethod]
         public void GetGuidList() {
 
             IQueryCollection query = new QueryCollection(new Dictionary<string, StringValues> {
-                {"guids", new StringValues(new[] { "7ce565ca-3dfe-4bc8-9166-4c4a5d1a9cbb", "a11c5663-d025-49be-93d7-876226dfd9b1", "nope", null })}
+                {"guids", new StringValues(new[] { "7ce565ca-3dfe-4bc8-9166-4c4a5d1a9cbb,8a2a3f66-898c-4b1e-8db7-efb8c08d4669", "a11c5663-d025-49be-93d7-876226dfd9b1", "nope", null })}
             });
 
             var guids = query.GetGuidList("guids");
 
-            Assert.AreEqual(2, guids.Count);
+            Assert.AreEqual(3, guids.Count);
 
             Assert.AreEqual("7ce565ca-3dfe-4bc8-9166-4c4a5d1a9cbb", guids[0].ToString());
-            Assert.AreEqual("a11c5663-d025-49be-93d7-876226dfd9b1", guids[1].ToString());
+            Assert.AreEqual("8a2a3f66-898c-4b1e-8db7-efb8c08d4669", guids[1].ToString());
+            Assert.AreEqual("a11c5663-d025-49be-93d7-876226dfd9b1", guids[2].ToString());
 
         }