Skip to content

Commit 0e36692

Browse files
abjernerabjerner
committed
More HttpClient parameters should allow null values
Underlying logic already has relevant null checks.
1 parent ce64b39 commit 0e36692

6 files changed

Lines changed: 20 additions & 20 deletions

File tree

‎src/Skybrud.Essentials.Http/Client/HttpClient.Delete.cs‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@ public virtual IHttpResponse Delete(string url, IHttpGetOptions options) {
3636
/// <param name="url">The URL of the request.</param>
3737
/// <param name="queryString">The query string of the request.</param>
3838
/// <returns>An instance of <see cref="IHttpResponse"/> representing the response.</returns>
39-
public virtual IHttpResponse Delete(string url, IHttpQueryString queryString) {
39+
public virtual IHttpResponse Delete(string url, IHttpQueryString? queryString) {
4040
if (string.IsNullOrWhiteSpace(url)) throw new ArgumentNullException(nameof(url));
4141
return GetResponse(HttpRequest.Delete(url, queryString));
4242
}

‎src/Skybrud.Essentials.Http/Client/HttpClient.Get.cs‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@ public virtual IHttpResponse Get(string url, IHttpGetOptions options) {
3636
/// <param name="url">The URL of the request.</param>
3737
/// <param name="queryString">The query string of the request.</param>
3838
/// <returns>An instance of <see cref="IHttpResponse"/> representing the response.</returns>
39-
public virtual IHttpResponse Get(string url, IHttpQueryString queryString) {
39+
public virtual IHttpResponse Get(string url, IHttpQueryString? queryString) {
4040
if (string.IsNullOrWhiteSpace(url)) throw new ArgumentNullException(nameof(url));
4141
return GetResponse(HttpRequest.Get(url, queryString));
4242
}

‎src/Skybrud.Essentials.Http/Client/HttpClient.Patch.cs‎

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,7 @@ public virtual IHttpResponse Patch(string url, IHttpPostOptions options) {
5252
/// <param name="url">The base URL of the request (no query string).</param>
5353
/// <param name="queryString">The query string.</param>
5454
/// <returns>An instance of <see cref="IHttpResponse"/> representing the raw response.</returns>
55-
public virtual IHttpResponse Patch(string url, IHttpQueryString queryString) {
55+
public virtual IHttpResponse Patch(string url, IHttpQueryString? queryString) {
5656
if (string.IsNullOrWhiteSpace(url)) throw new ArgumentNullException(nameof(url));
5757
return GetResponse(HttpRequest.Patch(url, queryString));
5858
}
@@ -63,7 +63,7 @@ public virtual IHttpResponse Patch(string url, IHttpQueryString queryString) {
6363
/// <param name="url">The base URL of the request (no query string).</param>
6464
/// <param name="postData">The POST data.</param>
6565
/// <returns>An instance of <see cref="IHttpResponse"/> representing the raw response.</returns>
66-
public virtual IHttpResponse Patch(string url, IHttpPostData postData) {
66+
public virtual IHttpResponse Patch(string url, IHttpPostData? postData) {
6767
if (string.IsNullOrWhiteSpace(url)) throw new ArgumentNullException(nameof(url));
6868
return GetResponse(HttpRequest.Patch(url, postData));
6969
}
@@ -75,7 +75,7 @@ public virtual IHttpResponse Patch(string url, IHttpPostData postData) {
7575
/// <param name="queryString">The query string of the request.</param>
7676
/// <param name="postData">The body of the request.</param>
7777
/// <returns>An instance of <see cref="IHttpResponse"/> representing the response.</returns>
78-
public virtual IHttpResponse Patch(string url, IHttpQueryString queryString, IHttpPostData postData) {
78+
public virtual IHttpResponse Patch(string url, IHttpQueryString? queryString, IHttpPostData? postData) {
7979
if (string.IsNullOrWhiteSpace(url)) throw new ArgumentNullException(nameof(url));
8080
return GetResponse(HttpRequest.Patch(url, queryString, postData));
8181
}
@@ -88,7 +88,7 @@ public virtual IHttpResponse Patch(string url, IHttpQueryString queryString, IHt
8888
/// <param name="contentType">The content type of the request - eg. <c>application/json</c>.</param>
8989
/// <param name="body">The body of the request.</param>
9090
/// <returns>An instance of <see cref="IHttpResponse"/> representing the response.</returns>
91-
public virtual IHttpResponse Patch(string url, IHttpQueryString queryString, string contentType, string body) {
91+
public virtual IHttpResponse Patch(string url, IHttpQueryString? queryString, string contentType, string body) {
9292
if (string.IsNullOrWhiteSpace(url)) throw new ArgumentNullException(nameof(url));
9393
return GetResponse(HttpRequest.Patch(url, queryString).SetContentType(contentType).SetBody(body));
9494
}
@@ -125,7 +125,7 @@ public virtual IHttpResponse Patch(string url, JToken body, Formatting formattin
125125
/// <param name="queryString">The query string.</param>
126126
/// <param name="body">The body of the request.</param>
127127
/// <returns>An instance of <see cref="IHttpResponse"/> representing the raw response.</returns>
128-
public virtual IHttpResponse Patch(string url, IHttpQueryString queryString, JToken body) {
128+
public virtual IHttpResponse Patch(string url, IHttpQueryString? queryString, JToken body) {
129129
if (string.IsNullOrWhiteSpace(url)) throw new ArgumentNullException(nameof(url));
130130
if (body == null) throw new ArgumentNullException(nameof(body));
131131
return GetResponse(HttpRequest.Patch(url, queryString, body));
@@ -139,7 +139,7 @@ public virtual IHttpResponse Patch(string url, IHttpQueryString queryString, JTo
139139
/// <param name="body">The body of the request.</param>
140140
/// <param name="formatting">The formatting to be used when serializing <paramref name="body"/>.</param>
141141
/// <returns>An instance of <see cref="IHttpResponse"/> representing the raw response.</returns>
142-
public virtual IHttpResponse Patch(string url, IHttpQueryString queryString, JToken body, Formatting formatting) {
142+
public virtual IHttpResponse Patch(string url, IHttpQueryString? queryString, JToken body, Formatting formatting) {
143143
if (string.IsNullOrWhiteSpace(url)) throw new ArgumentNullException(nameof(url));
144144
if (body == null) throw new ArgumentNullException(nameof(body));
145145
return GetResponse(HttpRequest.Patch(url, queryString, body, formatting));
@@ -177,7 +177,7 @@ public virtual IHttpResponse Patch(string url, XNode body, SaveOptions options)
177177
/// <param name="queryString">The query string.</param>
178178
/// <param name="body">The body of the request.</param>
179179
/// <returns>An instance of <see cref="IHttpResponse"/> representing the raw response.</returns>
180-
public virtual IHttpResponse Patch(string url, IHttpQueryString queryString, XNode body) {
180+
public virtual IHttpResponse Patch(string url, IHttpQueryString? queryString, XNode body) {
181181
if (string.IsNullOrWhiteSpace(url)) throw new ArgumentNullException(nameof(url));
182182
if (body == null) throw new ArgumentNullException(nameof(body));
183183
return GetResponse(HttpRequest.Patch(url, queryString, body));
@@ -191,7 +191,7 @@ public virtual IHttpResponse Patch(string url, IHttpQueryString queryString, XNo
191191
/// <param name="body">The body of the request.</param>
192192
/// <param name="options">The options to be used when serializing <paramref name="body"/>.</param>
193193
/// <returns>An instance of <see cref="IHttpResponse"/> representing the raw response.</returns>
194-
public virtual IHttpResponse Patch(string url, IHttpQueryString queryString, XNode body, SaveOptions options) {
194+
public virtual IHttpResponse Patch(string url, IHttpQueryString? queryString, XNode body, SaveOptions options) {
195195
if (string.IsNullOrWhiteSpace(url)) throw new ArgumentNullException(nameof(url));
196196
if (body == null) throw new ArgumentNullException(nameof(body));
197197
return GetResponse(HttpRequest.Patch(url, queryString, body, options));

‎src/Skybrud.Essentials.Http/Client/HttpClient.Put.cs‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -73,7 +73,7 @@ public virtual IHttpResponse Put(string url, IHttpPostData? postData) {
7373
/// <param name="queryString">The query string of the request.</param>
7474
/// <param name="postData">The body of the request.</param>
7575
/// <returns>An instance of <see cref="IHttpResponse"/> representing the response.</returns>
76-
public virtual IHttpResponse Put(string url, IHttpQueryString? queryString, IHttpPostData postData) {
76+
public virtual IHttpResponse Put(string url, IHttpQueryString? queryString, IHttpPostData? postData) {
7777
if (string.IsNullOrWhiteSpace(url)) throw new ArgumentNullException(nameof(url));
7878
return GetResponse(HttpRequest.Put(url, queryString, postData));
7979
}

‎src/Skybrud.Essentials.Http/Client/HttpClientAsync.Get.cs‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ public virtual async Task<IHttpResponse> GetAsync(string url) {
2323
/// <param name="url">The URL of the request.</param>
2424
/// <param name="queryString">The query string of the request.</param>
2525
/// <returns>An instance of <see cref="IHttpResponse"/> representing the response.</returns>
26-
public virtual async Task<IHttpResponse> GetAsync(string url, IHttpQueryString queryString) {
26+
public virtual async Task<IHttpResponse> GetAsync(string url, IHttpQueryString? queryString) {
2727
if (string.IsNullOrWhiteSpace(url)) throw new ArgumentNullException(nameof(url));
2828
return await GetResponseAsync(HttpRequest.Get(url, queryString));
2929
}

‎src/Skybrud.Essentials.Http/Client/HttpClientAsync.Patch.cs‎

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ public virtual async Task<IHttpResponse> PatchAsync(string url) {
2727
/// <param name="url">The base URL of the request (no query string).</param>
2828
/// <param name="queryString">The query string.</param>
2929
/// <returns>An instance of <see cref="IHttpResponse"/> representing the raw response.</returns>
30-
public virtual async Task<IHttpResponse> PatchAsync(string url, IHttpQueryString queryString) {
30+
public virtual async Task<IHttpResponse> PatchAsync(string url, IHttpQueryString? queryString) {
3131
if (string.IsNullOrWhiteSpace(url)) throw new ArgumentNullException(nameof(url));
3232
return await GetResponseAsync(HttpRequest.Patch(url, queryString));
3333
}
@@ -38,7 +38,7 @@ public virtual async Task<IHttpResponse> PatchAsync(string url, IHttpQueryString
3838
/// <param name="url">The base URL of the request (no query string).</param>
3939
/// <param name="postData">The POST data.</param>
4040
/// <returns>An instance of <see cref="IHttpResponse"/> representing the raw response.</returns>
41-
public virtual async Task<IHttpResponse> PatchAsync(string url, IHttpPostData postData) {
41+
public virtual async Task<IHttpResponse> PatchAsync(string url, IHttpPostData? postData) {
4242
if (string.IsNullOrWhiteSpace(url)) throw new ArgumentNullException(nameof(url));
4343
return await GetResponseAsync(HttpRequest.Patch(url, postData));
4444
}
@@ -50,7 +50,7 @@ public virtual async Task<IHttpResponse> PatchAsync(string url, IHttpPostData po
5050
/// <param name="queryString">The query string of the request.</param>
5151
/// <param name="postData">The body of the request.</param>
5252
/// <returns>An instance of <see cref="IHttpResponse"/> representing the response.</returns>
53-
public virtual async Task<IHttpResponse> PatchAsync(string url, IHttpQueryString queryString, IHttpPostData postData) {
53+
public virtual async Task<IHttpResponse> PatchAsync(string url, IHttpQueryString? queryString, IHttpPostData? postData) {
5454
if (string.IsNullOrWhiteSpace(url)) throw new ArgumentNullException(nameof(url));
5555
return await GetResponseAsync(HttpRequest.Patch(url, queryString, postData));
5656
}
@@ -63,7 +63,7 @@ public virtual async Task<IHttpResponse> PatchAsync(string url, IHttpQueryString
6363
/// <param name="contentType">The content type of the request - eg. <c>application/json</c>.</param>
6464
/// <param name="body">The body of the request.</param>
6565
/// <returns>An instance of <see cref="IHttpResponse"/> representing the response.</returns>
66-
public virtual async Task<IHttpResponse> PatchAsync(string url, IHttpQueryString queryString, string contentType, string body) {
66+
public virtual async Task<IHttpResponse> PatchAsync(string url, IHttpQueryString? queryString, string contentType, string body) {
6767
if (string.IsNullOrWhiteSpace(url)) throw new ArgumentNullException(nameof(url));
6868
return await GetResponseAsync(HttpRequest.Patch(url, queryString).SetContentType(contentType).SetBody(body));
6969
}
@@ -100,7 +100,7 @@ public virtual async Task<IHttpResponse> PatchAsync(string url, JToken body, For
100100
/// <param name="queryString">The query string.</param>
101101
/// <param name="body">The body of the request.</param>
102102
/// <returns>An instance of <see cref="IHttpResponse"/> representing the raw response.</returns>
103-
public virtual async Task<IHttpResponse> PatchAsync(string url, IHttpQueryString queryString, JToken body) {
103+
public virtual async Task<IHttpResponse> PatchAsync(string url, IHttpQueryString? queryString, JToken body) {
104104
if (string.IsNullOrWhiteSpace(url)) throw new ArgumentNullException(nameof(url));
105105
if (body == null) throw new ArgumentNullException(nameof(body));
106106
return await GetResponseAsync(HttpRequest.Patch(url, queryString, body));
@@ -114,7 +114,7 @@ public virtual async Task<IHttpResponse> PatchAsync(string url, IHttpQueryString
114114
/// <param name="body">The body of the request.</param>
115115
/// <param name="formatting">The formatting to be used when serializing <paramref name="body"/>.</param>
116116
/// <returns>An instance of <see cref="IHttpResponse"/> representing the raw response.</returns>
117-
public virtual async Task<IHttpResponse> PatchAsync(string url, IHttpQueryString queryString, JToken body, Formatting formatting) {
117+
public virtual async Task<IHttpResponse> PatchAsync(string url, IHttpQueryString? queryString, JToken body, Formatting formatting) {
118118
if (string.IsNullOrWhiteSpace(url)) throw new ArgumentNullException(nameof(url));
119119
if (body == null) throw new ArgumentNullException(nameof(body));
120120
return await GetResponseAsync(HttpRequest.Patch(url, queryString, body, formatting));
@@ -152,7 +152,7 @@ public virtual async Task<IHttpResponse> PatchAsync(string url, XNode body, Save
152152
/// <param name="queryString">The query string.</param>
153153
/// <param name="body">The body of the request.</param>
154154
/// <returns>An instance of <see cref="IHttpResponse"/> representing the raw response.</returns>
155-
public virtual async Task<IHttpResponse> PatchAsync(string url, IHttpQueryString queryString, XNode body) {
155+
public virtual async Task<IHttpResponse> PatchAsync(string url, IHttpQueryString? queryString, XNode body) {
156156
if (string.IsNullOrWhiteSpace(url)) throw new ArgumentNullException(nameof(url));
157157
if (body == null) throw new ArgumentNullException(nameof(body));
158158
return await GetResponseAsync(HttpRequest.Patch(url, queryString, body));
@@ -166,7 +166,7 @@ public virtual async Task<IHttpResponse> PatchAsync(string url, IHttpQueryString
166166
/// <param name="body">The body of the request.</param>
167167
/// <param name="options">The options to be used when serializing <paramref name="body"/>.</param>
168168
/// <returns>An instance of <see cref="IHttpResponse"/> representing the raw response.</returns>
169-
public virtual async Task<IHttpResponse> PatchAsync(string url, IHttpQueryString queryString, XNode body, SaveOptions options) {
169+
public virtual async Task<IHttpResponse> PatchAsync(string url, IHttpQueryString? queryString, XNode body, SaveOptions options) {
170170
if (string.IsNullOrWhiteSpace(url)) throw new ArgumentNullException(nameof(url));
171171
if (body == null) throw new ArgumentNullException(nameof(body));
172172
return await GetResponseAsync(HttpRequest.Patch(url, queryString, body, options));

0 commit comments

Comments
 (0)